From owner-freebsd-arch Fri Jul 7 23: 7:24 2000 Delivered-To: freebsd-arch@freebsd.org Received: from gateway.posi.net (c1096725-a.smateo1.sfba.home.com [24.20.139.104]) by hub.freebsd.org (Postfix) with ESMTP id 9D63137BAF1 for ; Fri, 7 Jul 2000 23:07:20 -0700 (PDT) (envelope-from kbyanc@posi.net) Received: from localhost (kbyanc@localhost) by gateway.posi.net (8.9.3/8.9.3) with ESMTP id XAA25016; Fri, 7 Jul 2000 23:11:04 -0700 (PDT) (envelope-from kbyanc@posi.net) Date: Fri, 7 Jul 2000 23:11:04 -0700 (PDT) From: Kelly Yancey To: Andrzej Bialecki Cc: freebsd-arch@FreeBSD.ORG Subject: Re: UPDATE2: Dynamic sysctls In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 8 Jul 2000, Andrzej Bialecki wrote: > Hi again, > > I received many useful comments regarding previous version, and made some > changes in functionality. The latest patches can be found at: > > http://www.freebsd.org/~abial/dyn_sysctl-070700.tgz > > Looking good. On style(9) nit (god knows I'm not the one to preach style(9) :) ): struct sysctl_ctx_entry *sysctl_ctx_entry_add(struct sysctl_ctx_list *clist, struct sysctl_oid *oidp) should be: struct sysctl_ctx_entry * sysctl_ctx_entry_add(struct sysctl_ctx_list *clist, struct sysctl_oid *oidp) By the way, did you get message I sent regarding the last patchset? I am still unsure how the warning comment in sysctl_remove_oid applys. Also, I'de like to know what you thought of the suggestion to remove all special knowledge of contexts from sysctl_add_oid. i.e. to remove context handling from sysctl_add_oid and make the modules using contexts do something like: oid = sysctl_add_oid(...) sysctl_ctx_entry_add(myctx, oid); or just: sysctl_ctx_entry_add(myctx, sysctl_add_oid(...)); I think it would clean up the sysctl_add_oid code and the interface in general. This is great work that you are doing. Thanks, Kelly -- Kelly Yancey - kbyanc@posi.net - Belmont, CA System Administrator, eGroups.com http://www.egroups.com/ Maintainer, BSD Driver Database http://www.posi.net/freebsd/drivers/ Coordinator, Team FreeBSD http://www.posi.net/freebsd/Team-FreeBSD/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message