From nobody Mon Apr 3 23:46:44 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pr6xM6Vr4z43Vnk; Mon, 3 Apr 2023 23:46:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pr6xM3vWlz3kDP; Mon, 3 Apr 2023 23:46:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4001a.ext.cloudfilter.net ([10.228.9.142]) by cmsmtp with ESMTP id jPXBpuUfNjvm1jTssphHn2; Mon, 03 Apr 2023 23:46:46 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id jTsqpIUCpHFsOjTsrp9Dss; Mon, 03 Apr 2023 23:46:46 +0000 X-Authority-Analysis: v=2.4 cv=XZqaca15 c=1 sm=1 tr=0 ts=642b6566 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=dKHAf1wccvYA:10 a=VxmjJ2MpAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=ZuGa5fMlZT1JjV0PVz0A:9 a=GKd2V1Gye9L_yD9j:21 a=CjuIK1q_8ugA:10 a=swc79zMUYnAA:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A26DC258; Mon, 3 Apr 2023 16:46:44 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 6C2A7126; Mon, 3 Apr 2023 16:46:44 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: Martin Matuska , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 In-reply-to: <20230403231444.CF48911F@slippy.cwsent.com> References: <202304031513.333FD6qw014903@gitrepo.freebsd.org> <20230403231444.CF48911F@slippy.cwsent.com> Comments: In-reply-to Cy Schubert message dated "Mon, 03 Apr 2023 16:14:44 -0700." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 03 Apr 2023 16:46:44 -0700 Message-Id: <20230403234644.6C2A7126@slippy.cwsent.com> X-CMAE-Envelope: MS4xfJceBdkbV74W6YxAIT6F6La68UZ7HdxbSS+NdYUu55jIX16AYRCBb/g8ov2EvQ+KvJXwivueOJfDeTLqD4wbdQe1QBMdCo4K5uU2304q8RHYEN65musU 2gx+nrZw8LZD7Alq30KDcJsUlc/TwHA1+WWX915T6roM/8T0E8zbQnDyYnm/lSMmSxs2M71cpr7rc8HtOSCMW7/kspuw+WrGDCFkC2VjEIO549lbFr4yTVep XdhEnA+KGv7+2075nhuRZ3b6nRKNSJFQy7qLLoTR4F8NO+MJ7DyTjIT5i8pBT8RP9aBETS1356U/8rnVldi388xqvtsQNlW4Z2jPC2OIKkY= X-Rspamd-Queue-Id: 4Pr6xM3vWlz3kDP X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <20230403231444.CF48911F@slippy.cwsent.com>, Cy Schubert writes: > In message <202304031513.333FD6qw014903@gitrepo.freebsd.org>, Martin > Matuska wr > ites: > > The branch main has been updated by mm: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2a58b312b62f908ec92311d1bd8536 > db > > aeb8e55b > > > > commit 2a58b312b62f908ec92311d1bd8536dbaeb8e55b > > Merge: b98fbf3781df 431083f75bdd > > Author: Martin Matuska > > AuthorDate: 2023-04-03 14:49:30 +0000 > > Commit: Martin Matuska > > CommitDate: 2023-04-03 14:49:30 +0000 > > > > zfs: merge openzfs/zfs@431083f75 > > > > Notable upstream pull request merges: > > #12194 Fix short-lived txg caused by autotrim > > #13368 ZFS_IOC_COUNT_FILLED does unnecessary txg_wait_synced() > > #13392 Implementation of block cloning for ZFS > > #13741 SHA2 reworking and API for iterating over multiple implementat > io > > ns > > #14282 Sync thread should avoid holding the spa config write lock > > when possible > > #14283 txg_sync should handle write errors in ZIL > > #14359 More adaptive ARC eviction > > #14469 Fix NULL pointer dereference in zio_ready() > > #14479 zfs redact fails when dnodesize=auto > > #14496 improve error message of zfs redact > > #14500 Skip memory allocation when compressing holes > > #14501 FreeBSD: don't verify recycled vnode for zfs control directory > > #14502 partially revert PR 14304 (eee9362a7) > > #14509 Fix per-jail zfs.mount_snapshot setting > > #14514 Fix data race between zil_commit() and zil_suspend() > > #14516 System-wide speculative prefetch limit > > #14517 Use rw_tryupgrade() in dmu_bonus_hold_by_dnode() > > #14519 Do not hold spa_config in ZIL while blocked on IO > > #14523 Move dmu_buf_rele() after dsl_dataset_sync_done() > > #14524 Ignore too large stack in case of dsl_deadlist_merge > > #14526 Use .section .rodata instead of .rodata on FreeBSD > > #14528 ICP: AES-GCM: Refactor gcm_clear_ctx() > > #14529 ICP: AES-GCM: Unify gcm_init_ctx() and gmac_init_ctx() > > #14532 Handle unexpected errors in zil_lwb_commit() without ASSERT() > > #14544 icp: Prevent compilers from optimizing away memset() > > in gcm_clear_ctx() > > #14546 Revert zfeature_active() to static > > #14556 Remove bad kmem_free() oversight from previous zfsdev_state_li > st > > patch > > #14563 Optimize the is_l2cacheable functions > > #14565 FreeBSD: zfs_znode_alloc: lock the vnode earlier > > #14566 FreeBSD: fix false assert in cache_vop_rmdir when replaying ZI > L > > #14567 spl: Add cmn_err_once() to log a message only on the first cal > l > > #14568 Fix incremental receive silently failing for recursive sends > > #14569 Restore ASMABI and other Unify work > > #14576 Fix detection of IBM Power8 machines (ISA 2.07) > > #14577 Better handling for future crypto parameters > > #14600 zcommon: Refactor FPU state handling in fletcher4 > > #14603 Fix prefetching of indirect blocks while destroying > > #14633 Fixes in persistent error log > > #14639 FreeBSD: Remove extra arc_reduce_target_size() call > > #14641 Additional limits on hole reporting > > #14649 Drop lying to the compiler in the fletcher4 code > > #14652 panic loop when removing slog device > > #14653 Update vdev state for spare vdev > > #14655 Fix cloning into already dirty dbufs > > #14678 Revert "Do not hold spa_config in ZIL while blocked on IO" > > > > Obtained from: OpenZFS > > OpenZFS commit: 431083f75bdd3efaee992bdd672625ec7240d252 > > Just a heads up, I'm encountering the following error with an NFS share of > a ZFS dataset. > > Fatal trap 12: page fault while in kernel mode > cpuid = 1; apic id = 01 > fault virtual address = 0x178 > fault code = supervisor read data, page not present > instruction pointer = 0x20:0xffffffff814eebcd > stack pointer = 0x28:0xfffffe00ec6c7cd0 > frame pointer = 0x28:0xfffffe00ec6c7d50 > code segment = base 0x0, limit 0xfffff, type 0x1b > = DPL 0, pres 1, long 1, def32 0, gran 1 > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 3735 (nfsd: master) > rdi: fffff8020a6f8570 rsi: fffffe00ec6c80d8 rdx: fffff8020f56f3a0 > rcx: fffffe00ec6c80e0 r8: 0 r9: 1000000 > rax: 0 rbx: fffff80210123540 rbp: fffffe00ec6c7d50 > r10: 1876 r11: ffffffff81714596 r12: fffffe00ec6c7d20 > r13: 0 r14: fffff8020b2f3e00 r15: fffffe00ec6c7d68 > trap number = 12 > panic: page fault > cpuid = 1 > time = 1680563351 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe00ec6c7a90 > vpanic() at vpanic+0x152/frame 0xfffffe00ec6c7ae0 > panic() at panic+0x43/frame 0xfffffe00ec6c7b40 > trap_fatal() at trap_fatal+0x409/frame 0xfffffe00ec6c7ba0 > trap_pfault() at trap_pfault+0x4f/frame 0xfffffe00ec6c7c00 > calltrap() at calltrap+0x8/frame 0xfffffe00ec6c7c00 > --- trap 0xc, rip = 0xffffffff814eebcd, rsp = 0xfffffe00ec6c7cd0, rbp = > 0xfffffe00ec6c7d50 --- > zfs_freebsd_copy_file_range() at zfs_freebsd_copy_file_range+0x1bd/frame > 0xfffffe00ec6c7d50 > vn_copy_file_range() at vn_copy_file_range+0x11f/frame 0xfffffe00ec6c7df0 > nfsrvd_copy_file_range() at nfsrvd_copy_file_range+0x7d1/frame > 0xfffffe00ec6c81c0 > nfsrvd_dorpc() at nfsrvd_dorpc+0x17b5/frame 0xfffffe00ec6c83f0 > nfssvc_program() at nfssvc_program+0x6dd/frame 0xfffffe00ec6c85e0 > svc_run_internal() at svc_run_internal+0xb0f/frame 0xfffffe00ec6c8720 > svc_run() at svc_run+0x1b7/frame 0xfffffe00ec6c8770 > nfsrvd_nfsd() at nfsrvd_nfsd+0x364/frame 0xfffffe00ec6c88d0 > nfssvc_nfsd() at nfssvc_nfsd+0x58b/frame 0xfffffe00ec6c8de0 > sys_nfssvc() at sys_nfssvc+0x9c/frame 0xfffffe00ec6c8e00 > amd64_syscall() at amd64_syscall+0x109/frame 0xfffffe00ec6c8f30 > fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe00ec6c8f30 > --- syscall (155, FreeBSD ELF64, nfssvc), rip = 0x2c12ca606bea, rsp = > 0x2c12c7614098, rbp = 0x2c12c7614330 --- > Uptime: 39m11s > Dumping 1426 out of 8159 MB:..2%..11%..21%..31%..41%..51%..61%..71%..81%..91 > % > Dump complete > acpi0: reset failed - timeout > Automatic reboot in 15 seconds - press a key on the console to abort > Rebooting... > cpu_reset: Restarting BSP > cpu_reset_proxy: Stopped CPU 1 > > > I haven't had a chance to look at the dump yet. The block_cloning feature > has not been enabled yet. Here we go: Backtrace: (kgdb) bt #0 __curthread () at /opt/src/git-src/sys/amd64/include/pcpu_aux.h:59 #1 doadump (textdump=textdump@entry=1) at /opt/src/git-src/sys/kern/kern_sh utdown.c:407 #2 0xffffffff806c3f07 in kern_reboot (howto=260) at /opt/src/git-src/sys/kern/kern_shutdown.c:528 #3 0xffffffff806c440f in vpanic (fmt=, ap=ap@entry=0xfffffe00f7b1f2e0) at /opt/src/git-src/sys/kern/kern_shutdown.c:972 #4 0xffffffff806c4243 in panic (fmt=) at /opt/src/git-src/sys/kern/kern_shutdown.c:896 #5 0xffffffff80a4e1e9 in trap_fatal (frame=0xfffffe00f7b1f3d0, eva=376) at /opt/src/git-src/sys/amd64/amd64/trap.c:954 #6 0xffffffff80a4e23f in trusermode=false, signo=, ucode=) at /opt/src/git-src/sys/amd64/amd64/trap.c:762 #7 #8 0xffffffff81294bcd in zfs_freebsd_copy_file_range (ap=0xfffffe00f7b1f528) at /opt/src/git-src/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_ os.c:6293 #9 0xffffffff807c80cf in VOP_COPY_FILE_RANGE (invp=, inoffp=0xfffffe00f7b1f898, outvp=0xfffff8019649b3a0, outoffp=0xfffffe00f7b1f8a0, lenp=0x0, flags=16777216, incred=0xfffff800542b1000, outcred=0xffffffff814ba596, fsizetd=0x0) at ./vnode_if.h:2383 #10 vn_copy_file_range (invp=invp@entry=0xfffff80151a8de00, inoffp=inoffp@entry=0xfffffe00f7b1f898, outvp=0xfffff8019649b3a0, outvp@entry=0xfffff8018bbd4a80, outoffp=outoffp@entry=0xfffffe00f7b1f8a0, lenp=0x0, lenp@entry=0xfffffe00f7b1f910, flags=flags@entry=16777216, incred=0xfffff800542b1000, outcred=0xfffff800542b1000, fsize_td=0x0) at /opt/src/git-src/sys/kern/vfs_vnops.c:3078 #11 0xffffffff805d3001 in nfsrvd_copy_file_range (nd=0xfffffe00f7b1fbf8, isdgram=, vp=0xfffff80151a8de00, tovp=0xfffff8018bbd4a80, exp=, toexp=) at /opt/src/git-src/sys/fs/nfsserver/nfs_nfsdserv.c:5744 #12 0xffffffff805afe05 in nfsrvd_compound (nd=0xfffffe00f7b1fbf8, isdgram=0, tag=, taglen=4, minorvers=) at /opt/src/git-src/sys/fs/nfsserver/nfs_nfsd socket.c:1257 #13 nfsrvd_dorpc (nd=nd@entry=0xfffffe00f7b1fbf8, isdgram=isdgram@entry=0, tag=, taglen=4, minorvers=) at /opt/src/git-src/sys/fs/nfsserver/nfs_nfsd socket.c:631 #14 0xffffffff805c6c2d in nfs_proc (nd=0xfffffe00f7b1fbf8, xid=, xprt=0xfffff8003c88f800, rpp=) at /opt/src/git-src/sys/fs/nfsserver/nfs_nfsdkrpc.c :410 #15 nfssvc_program (rqst=0xfffff80025fc4000, xprt=0xfffff8003c88f800) at /opt/src/git-src/sys/fs/nfsserver/nfs_nfsdkrpc.c:295 #16 0xffffffff8091513f in svc_executereq (rqstp=0xfffff80025fc4000) at /opt/src/git-src/sys/rpc/svc.c:1038 #17 svc_run_internal (grp=grp@entry=0xfffff800067dc100, ismaster=ismaster@entry=0) at /opt/src/git-src/sys/rpc/svc.c:1314 #18 0xffffffff8091590b in svc_thread_start (arg=0xfffff8015128c910, arg@entry=0xfffff800067dc100) at /opt/src/git-src/sys/rpc/svc.c:1342 #19 0xffffffff8067db9d in fork_exit (callout=0xffffffff80915900 , arg=0xfffff800067dc100, frame=0xfffffe00f7b1ff40) at /opt/src/git-src/sys/kern/kern_fork.c:1102 #20 #21 0x00002aa7859a8bea in ?? () Backtrace stopped: Cannot access memory at address 0x2aa783e7e4f8 At frame 8: (kgdb) frame 8 #8 0xffffffff81294bcd in zfs_freebsd_copy_file_range (ap=0xfffffe00f7b1f528) at /opt/src/git-src/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_ os.c:6293 6293 ap->a_outoffp, &len, ap->a_fsizetd->td_ucred); (kgdb) l 6288 error = vn_rlimit_fsize(outvp, &io, ap->a_fsizetd); 6289 if (error != 0) 6290 goto unlock; 6291 6292 error = zfs_clone_range(VTOZ(invp), ap->a_inoffp, VTOZ(outvp), 6293 ap->a_outoffp, &len, ap->a_fsizetd->td_ucred); ^^^^^^^^^^^^^^^^^^^^^^^ The problem is here. 6294 *ap->a_lenp = (size_t)len; 6295 6296 unlock: 6297 if (invp != outvp) (kgdb) (kgdb) x ap->a_fsizetd 0x0: Cannot access memory at address 0x0 (kgdb) -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0