From owner-svn-src-head@freebsd.org Sun Jul 8 00:51:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3038810432C9 for ; Sun, 8 Jul 2018 00:51:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A907B75D02 for ; Sun, 8 Jul 2018 00:51:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id y124-v6so8548899itc.0 for ; Sat, 07 Jul 2018 17:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y+8FVg87mrsWwvUAmrsjpOujLtwBdRefk8XDE4CSRks=; b=UrxZzXp1KLJRiY000WnAm5B/GClXaD3EUugztMzV1eL72AoEhCTfONV4+zQ8clyVMJ 1ojRyjDHNlyFqjuMDIkjkc920oKivCtPUd5C1EpiBv6C31DD8VHyQjt8PoP58rPR3Vrk gbtzWjjTASzUY/0baTDKrLGys1WMwy0g+yMfy97Y7q1niMctvmVveTli+1I93Y/Gx58c IU2h+EbKL8xReHOYTqBTO9zRdgM5gmMDV+gLNSYX5bQK1o2iOVpRH+cUDkDdG90iovKj cctqtyeSA/fDbrgKdoBdBj7kxgQLHI5KwPezNdIrhHokezWHsQIRV1bh7eHjuPiat/l/ L+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y+8FVg87mrsWwvUAmrsjpOujLtwBdRefk8XDE4CSRks=; b=ELO63Ya9G6no/rqEmVoTo4dfUo6a136HqTeoHZO4YBQNURDLcoQ1Ly2pUSdwSMCRio GXUKSGFhPQE1kIJelUBuWp6aKFh2swZKLvMj3ByqsaSfs5IkpWxMH/KP0MfMcmgwf+oG wGgIuinwh9xGeLbSgpetO12qDlJvValBee71ZqarFO/O//2bBraW7P9GTnpV1z3136e8 ABY658IGE5YvaFw6sY7Tkq9FS1SOZ2PQuY6O0gOjQAnDRWXZFOIg2dMTWCcY6clNoSUx 3Sc7UmEbm9VOYjZIWkbfxeP8l/MX/GWGg0sL0iK4K86Lb1aC6rxzBVyh18g7DECiNfnF TE/w== X-Gm-Message-State: APt69E1Qeb/+3bF6o2SXpbtDOaAVUBcDvktsYeaD8U51NhUX5cAkT5iV nh25Txs5/55vQbUc7/jN0ilq5haScQcxEctMJyBniw== X-Google-Smtp-Source: AAOMgpfFheMkbrMkVNXH2JtjMUPua9H4UlmV+quYj/R3T5YLwVefmXFWT2jMGbbyXye6SoDFJ9l3EgsMvSCVkYefscw= X-Received: by 2002:a24:d0d7:: with SMTP id m206-v6mr11786432itg.1.1531011081911; Sat, 07 Jul 2018 17:51:21 -0700 (PDT) MIME-Version: 1.0 References: <201807071555.w67FtqrL004956@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 7 Jul 2018 18:51:09 -0600 Message-ID: Subject: Re: svn commit: r336068 - in head/sys: dev/amdsmb modules/amdsmb To: Andriy Gapon Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 00:51:23 -0000 On Sat, Jul 7, 2018, 6:42 PM Andriy Gapon wrote: > On 07/07/2018 18:55, Warner Losh wrote: > > Author: imp > > Date: Sat Jul 7 15:55:52 2018 > > New Revision: 336068 > > URL: https://svnweb.freebsd.org/changeset/base/336068 > > > > Log: > > Update AMDSMB to use PCI_MATCH > > Just curious if anyone still uses this driver for ancient hardware. > maybe de-orbit time? > No. All such discussions are on hold until I get the depreciation doc done, due by the end of the month. Then it might be a good one, but there is a lot in line in front of it... > Differential Review: https://reviews.freebsd.org/D16172 > > Just curious what's the point of referencing a review request that > - had no reviewers > - had no reviews > - does not even have a description > I shared it there for my GSoC student, and it wound up getting pushed as part of a different commute train by mistake. Warner > Added: > > head/sys/modules/amdsmb/ > > head/sys/modules/amdsmb/Makefile (contents, props changed) > > Modified: > > head/sys/dev/amdsmb/amdsmb.c > > > > Modified: head/sys/dev/amdsmb/amdsmb.c > > > ============================================================================== > > --- head/sys/dev/amdsmb/amdsmb.c Sat Jul 7 15:25:16 2018 > (r336067) > > +++ head/sys/dev/amdsmb/amdsmb.c Sat Jul 7 15:55:52 2018 > (r336068) > > @@ -125,24 +125,22 @@ struct amdsmb_softc { > > > > static int amdsmb_detach(device_t dev); > > > > +struct pci_device_table amdsmb_devs[] = { > > + { PCI_DEV(AMDSMB_VENDORID_AMD, AMDSMB_DEVICEID_AMD8111_SMB2), > > + PCI_DESCR("AMD-8111 SMBus 2.0 Controller") } > > +}; > > + > > static int > > amdsmb_probe(device_t dev) > > { > > - u_int16_t vid; > > - u_int16_t did; > > + const struct pci_device_table *tbl; > > > > - vid = pci_get_vendor(dev); > > - did = pci_get_device(dev); > > + tbl = PCI_MATCH(dev, amdsmb_devs); > > + if (tbl == NULL) > > + return (ENXIO); > > + device_set_desc(dev, tbl->descr); > > > > - if (vid == AMDSMB_VENDORID_AMD) { > > - switch(did) { > > - case AMDSMB_DEVICEID_AMD8111_SMB2: > > - device_set_desc(dev, "AMD-8111 SMBus 2.0 > Controller"); > > - return (BUS_PROBE_DEFAULT); > > - } > > - } > > - > > - return (ENXIO); > > + return (BUS_PROBE_DEFAULT); > > } > > > > static int > > > > Added: head/sys/modules/amdsmb/Makefile > > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/sys/modules/amdsmb/Makefile Sat Jul 7 15:55:52 2018 > (r336068) > > @@ -0,0 +1,8 @@ > > +# $FreeBSD$ > > + > > +.PATH: ${SRCTOP}/sys/dev/amdsmb > > + > > +KMOD= amdsmb > > +SRCS= amdsmb.c bus_if.h device_if.h pci_if.h smbus_if.h > > + > > +.include > > > > > -- > Andriy Gapon >