From owner-freebsd-hackers@FreeBSD.ORG Mon Dec 2 20:36:15 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7627483E for ; Mon, 2 Dec 2013 20:36:15 +0000 (UTC) Received: from zimbra2.tngtech.com (zimbra2.tngtech.com [212.204.93.103]) by mx1.freebsd.org (Postfix) with ESMTP id 0A4571365 for ; Mon, 2 Dec 2013 20:36:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by zimbra2.tngtech.com (Postfix) with ESMTP id A80A99CE0E7 for ; Mon, 2 Dec 2013 21:28:57 +0100 (CET) X-Virus-Scanned: amavisd-new at tngtech.com Received: from zimbra2.tngtech.com ([127.0.0.1]) by localhost (zimbra2.tngtech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HBPxI8-LKINe for ; Mon, 2 Dec 2013 21:28:25 +0100 (CET) Received: from hactar.localnet (mnch-5d856701.pool.mediaWays.net [93.133.103.1]) by zimbra2.tngtech.com (Postfix) with ESMTPSA id C2C279CE10B for ; Mon, 2 Dec 2013 21:28:25 +0100 (CET) From: Stefan Wendler To: freebsd-hackers@freebsd.org Subject: Kind of hacky fix for banshee-2.6.0 Date: Mon, 02 Dec 2013 21:28:24 +0100 Message-ID: <3074012.QmsohyHcnK@hactar> Organization: TNG Technology Consulting GmbH User-Agent: KMail/4.10.5 (FreeBSD/9.2-RELEASE; KDE/4.10.5; amd64; ; ) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart7368799.mJgcGonVU6" Content-Transfer-Encoding: 7Bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 20:36:15 -0000 This is a multi-part message in MIME format. --nextPart7368799.mJgcGonVU6 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, I've noticed a long time ago that banshee was not compiling anymore. When I wrote the maintainer nobody replied. So I kind of dirty-hacky-fixed it myself today. I generally did the following: I the Makefile.in files of the sources I changed (where this variable was available) ASSEMBLY_BUILD_FLAGS = -unsafe to ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 Then I compiled my way through the rest of the sources and found loads of other files where this line was missing completely. I started by including it by hand but after the 20th Makefile.in it somehow got tedious. so I did a "export ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4" and then a make install. Now it compiles and banshee works. I attached the patch fle that can be copied to multimedia/banshee/files and works-for-me (TM) But I still have to do the export-thing before compiling. And I know this is a dirty hack. But I don't know if there is a way to include this once as a global compile time variable. Or if I have to patch this into every Makefile.in there is in banshee? Since I never did any patch at all for FreeBSD so far and didn't find anything about setting a global variable in the ports Makefile, I kind of hope that there is anybody out there who can guide me in the right direction? Cheers, Stefan --nextPart7368799.mJgcGonVU6 Content-Disposition: attachment; filename="patch-sdk4" Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"; name="patch-sdk4" $FreeBSD$ --- src/Backends/Banshee.Osx/Makefile.in +++ src/Backends/Banshee.Osx/Makefile.in @@ -416,7 +416,7 @@ top_build_prefix = @top_build_prefix@ top_builddir = @top_builddir@ top_srcdir = @top_srcdir@ ASSEMBLY = Banshee.Osx -ASSEMBLY_BUILD_FLAGS = -unsafe +ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 TARGET = library LINK = $(REF_BACKEND_OSX) $(am__append_1) INSTALL_DIR = $(BACKENDS_INSTALL_DIR) --- src/Core/Banshee.ThickClient/Makefile.in +++ src/Core/Banshee.ThickClient/Makefile.in @@ -417,7 +417,7 @@ top_builddir = @top_builddir@ top_srcdir = @top_srcdir@ ASSEMBLY = Banshee.ThickClient TARGET = library -ASSEMBLY_BUILD_FLAGS = -unsafe +ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 LINK = $(REF_BANSHEE_THICKCLIENT) $(am__append_1) SOURCES = \ Banshee.Addins.Gui/AddinView.cs \ --- src/Core/Banshee.Widgets/Makefile.in +++ src/Core/Banshee.Widgets/Makefile.in @@ -417,7 +417,7 @@ top_builddir = @top_builddir@ top_srcdir = @top_srcdir@ ASSEMBLY = Banshee.Widgets TARGET = library -ASSEMBLY_BUILD_FLAGS = -unsafe +ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 LINK = $(REF_BANSHEE_WIDGETS) $(am__append_1) SOURCES = \ Banshee.Widgets/CustomActionProxy.cs \ --- src/Hyena/Hyena.Gui/Makefile.in +++ src/Hyena/Hyena.Gui/Makefile.in @@ -416,7 +416,7 @@ top_build_prefix = @top_build_prefix@ top_builddir = @top_builddir@ top_srcdir = @top_srcdir@ ASSEMBLY = Hyena.Gui -ASSEMBLY_BUILD_FLAGS = -unsafe +ASSEMBLY_BUILD_FLAGS = -unsafe -sdk:4 TARGET = library LINK = -r:ICSharpCode.SharpZipLib -r:Mono.Posix -r:System \ -r:System.Core -r:Mono.Cairo $(GTKSHARP_LIBS) \ --nextPart7368799.mJgcGonVU6--