From owner-freebsd-bugs  Fri Feb 12 10:10:08 1999
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id KAA14073
          for freebsd-bugs-outgoing; Fri, 12 Feb 1999 10:10:08 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA14025
          for <freebsd-bugs@FreeBSD.org>; Fri, 12 Feb 1999 10:10:02 -0800 (PST)
          (envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.2/8.9.2) id KAA76408;
	Fri, 12 Feb 1999 10:10:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from dreams.dragondata.com (oven.dragondata.com [204.137.237.253] (may be forged))
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA13862
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 12 Feb 1999 10:06:46 -0800 (PST)
          (envelope-from toasty@dreams.dragondata.com)
Received: (from root@localhost)
	by dreams.dragondata.com (8.9.1/8.9.1) id MAA15725;
	Fri, 12 Feb 1999 12:08:27 -0600 (CST)
	(envelope-from toasty)
Message-Id: <199902121808.MAA15725@dreams.dragondata.com>
Date: Fri, 12 Feb 1999 12:08:27 -0600 (CST)
From: toasty@dragondata.com
Reply-To: toasty@dragondata.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: i386/10050: [PATCH] identcpu.c slightly broken
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         10050
>Category:       i386
>Synopsis:       [PATCH] identcpu.c slightly broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 12 10:10:00 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Kevin Day
>Release:        FreeBSD 3.0-RELEASE i386
>Organization:
DragonData Internet Services
>Environment:



>Description:

sys/i386/i386/identcpu.c has two minor bugs, involving ANDing cpu_id

>How-To-Repeat:

>Fix:
	
--- identcpu.c  Fri Feb 12 18:55:19 1999
+++ identcpu.c  Fri Feb 12 18:58:02 1999
@@ -131,7 +131,7 @@
 
 #if defined(I486_CPU) || defined(I586_CPU) || defined(I686_CPU)
        if (strcmp(cpu_vendor,"GenuineIntel") == 0) {
-               if ((cpu_id & 0xf00) > 3) {
+               if ((cpu_id & 0xf00) > 0x300) {
                        cpu_model[0] = '\0';
 
                        switch (cpu_id & 0x3000) {
@@ -495,7 +495,7 @@
        if (strcmp(cpu_vendor, "GenuineIntel") == 0 ||
            strcmp(cpu_vendor, "AuthenticAMD") == 0 ||
                ((strcmp(cpu_vendor, "CyrixInstead") == 0) &&
-                ((cpu_id & 0xf00) > 5))) {
+                ((cpu_id & 0xf00) > 0x500))) {
                printf("  Stepping=%u", cpu_id & 0xf);
                if (strcmp(cpu_vendor, "CyrixInstead") == 0)
                        printf("  DIR=0x%04x", cyrix_did);
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message