From owner-freebsd-ports Thu Aug 12 6:37: 9 1999 Delivered-To: freebsd-ports@freebsd.org Received: from smtp13.bellglobal.com (smtp13.bellglobal.com [204.101.251.52]) by hub.freebsd.org (Postfix) with ESMTP id 9831715014 for ; Thu, 12 Aug 1999 06:37:04 -0700 (PDT) (envelope-from vanderh@ecf.toronto.edu) Received: from localhost.nowhere (ppp18409.on.bellglobal.com [206.172.130.89]) by smtp13.bellglobal.com (8.8.5/8.8.5) with ESMTP id JAA01435; Thu, 12 Aug 1999 09:38:23 -0400 (EDT) Received: (from tim@localhost) by localhost.nowhere (8.9.3/8.9.1) id JAA45013; Thu, 12 Aug 1999 09:38:35 -0400 (EDT) (envelope-from tim) Date: Thu, 12 Aug 1999 09:38:35 -0400 From: Tim Vanderhoek To: Anton Berezin Cc: Bill Fumerola , freebsd-ports@FreeBSD.ORG Subject: Re: ports/13030: Many ports use ``chown'' rather than ``/usr/sbin/chown'' in their Makefiles Message-ID: <19990812093835.A44972@mad> References: <19990809083649.B97354@mad> <19990812125750.B56987@lion.plab.ku.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95i In-Reply-To: <19990812125750.B56987@lion.plab.ku.dk>; from Anton Berezin on Thu, Aug 12, 1999 at 06:57:50AM -0400 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Thu, Aug 12, 1999 at 06:57:50AM -0400, Anton Berezin wrote: > # skip clever CHOWN assignments - they are unnecessary > next if m%^\s*CHOWN\s*\??=\s*(?:/usr/sbin/)?chown\s*$%; The script should probably bleat if it sees this. > # change all /usr/sbin/chown for ${CHOWN} > s%/usr/sbin/chown%\${CHOWN}%g; Better add \s+ to the start of that, just to be safe. Shouldn't make a difference, but consider linux_base, which does somethign like ${PREFIX}/sbin/ldconfig. Such an instance should be left hardcoded. -- This is my .signature which gets appended to the end of my messages. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message