From owner-freebsd-net@FreeBSD.ORG  Fri Aug 22 22:04:04 2008
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C00AA106567B;
	Fri, 22 Aug 2008 22:04:04 +0000 (UTC)
	(envelope-from gnn@neville-neil.com)
Received: from proxy.meer.net (proxy.meer.net [64.13.141.13])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D13B8FC25;
	Fri, 22 Aug 2008 22:04:04 +0000 (UTC)
	(envelope-from gnn@neville-neil.com)
Received: from mail.meer.net (mail.meer.net [64.13.141.3])
	by proxy.meer.net (8.14.2/8.14.2) with ESMTP id m7MM42Hw009563;
	Fri, 22 Aug 2008 15:04:03 -0700 (PDT)
	(envelope-from gnn@neville-neil.com)
Received: from mail2.meer.net (mail2.meer.net [64.13.141.16])
	by mail.meer.net (8.13.3/8.13.3/meer) with ESMTP id m7MM3Uqb060736;
	Fri, 22 Aug 2008 15:03:30 -0700 (PDT)
	(envelope-from gnn@neville-neil.com)
Received: from minion.local.neville-neil.com
	(ppp-71-139-4-101.dsl.snfc21.pacbell.net [71.139.4.101])
	(authenticated bits=0)
	by mail2.meer.net (8.14.1/8.14.1) with ESMTP id m7MM3UAs079032;
	Fri, 22 Aug 2008 15:03:30 -0700 (PDT)
	(envelope-from gnn@neville-neil.com)
Date: Fri, 22 Aug 2008 15:03:30 -0700
Message-ID: <m28wuohfm5.wl%gnn@neville-neil.com>
From: gnn@FreeBSD.org
To: "Bruce M. Simpson" <bms@FreeBSD.org>
In-Reply-To: <48AF330B.4010802@FreeBSD.org>
References: <m27iaa6v43.wl%gnn@neville-neil.com>
	<20080821203519.GA51534@onelab2.iet.unipi.it>
	<m23aky6ncl.wl%gnn@neville-neil.com> <48AE23FF.9070009@FreeBSD.org>
	<m2tzdd6j36.wl%gnn@neville-neil.com> <48AF08B7.4090804@FreeBSD.org>
	<m2fxowhgq8.wl%gnn@neville-neil.com> <48AF330B.4010802@FreeBSD.org>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka)
	FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.2.50
	(i386-apple-darwin9.4.0) MULE/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-Canit-CHI2: 0.50
X-Bayes-Prob: 0.5 (Score 0, tokens from: )
X-Spam-Score: 0.10 () [Tag at 5.00] COMBINED_FROM
X-CanItPRO-Stream: default
X-Canit-Stats-ID: 1317975 - c04b33cd274d
X-Scanned-By: CanIt (www . roaringpenguin . com) on 64.13.141.13
Cc: Luigi Rizzo <rizzo@iet.unipi.it>, net@FreeBSD.org
Subject: Re: Small patch to multicast code...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Aug 2008 22:04:04 -0000

At Fri, 22 Aug 2008 22:43:39 +0100,
Bruce M. Simpson wrote:
> 
> gnn@FreeBSD.org wrote:
> > Somehow the data that the device needs to do the proper checksum
> > offload is getting trashed here.  Now, since it's clear we need a
> > writable packet structure so that we don't trash the original, I'm
> > wondering if the m_pullup() will be sufficient.
> >   
> 
> If it's serious enough to break UDP checksumming on the wire, perhaps we 
> should just swallow the mbuf allocator heap churn and do the m_dup() for 
> now, but slap in a big comment about why it's there.

I think if none of us finds a better way before early next week that's
what I'll do so that this at least works in 7.1.

Best,
George