From nobody Mon Dec 15 17:00:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dVRBc6M6kz6L1d5 for ; Mon, 15 Dec 2025 17:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dVRBc2hMKz3p80 for ; Mon, 15 Dec 2025 17:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765818008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bU941XiXlZtzcyQc2VVNcexlvgSN0bzOzurgOfPCbZc=; b=WC/D7yl9UOofZTm5W2XW0T6/8oWfhhAts8a5BTKaJ9l7exIrCHjNosK+cBP9DFVmFPT+zx PPV6j783m5aun2EaqAwZ1uE4y8j/gyTZ98kOxqZv4bobXxZTfspXF2po3T1zv0+UCHP1Rq rOgRVyccw5qRGC38V53CprUstxaBrv2OP2zgvwguEL6F36vnlBm5I3hqwUuCmn4wukXkqm SgqkhHD7Okee3k5BHxtly1PccFJ0InlT0/OSzyarpbYeLkXZxQ0Wuw26zWZwPS4Yx0HYbA iz7F+7b4IZZ0vJNTGnQAaf5nDBVmF1SInhjBpHrUjP7ZKNyjZhZ5LTGMWvzILw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765818008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bU941XiXlZtzcyQc2VVNcexlvgSN0bzOzurgOfPCbZc=; b=g5cc29L969IPzrnd3DQZU8CAHXV3juqIVxMuLfRI7KGWjGEUehU9kyETbZE/yB+FM6i4/k Nv3POlOOfkbN8UjViJcccjLuWF/CgWh7Q+jQEF3TFL4h/twUX8j4luBpTV7YHjXGT3pVJQ n8jkPxT2j9ofEu8LU6B8XE1qBCUuAWdmeQ1iNLQQqvZsRnO3x9b+s4AQVzWhuAEHBtrW5m cZ7UJL5ovN7R74uQ1BUqmW8MPKNdISnkMIcHineTc00dyeDKD+OTJVtcf/xe4JBSarA0CC K13VMJN5U4IXHmUhXe85UW2BMcDkXSlwWit1doZQQJK15L4v0fKgIvN1k+bBmw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765818008; a=rsa-sha256; cv=none; b=LU19SvJzbrbCJYshh5cy14Aw7jtZYnkcfPLdfa2syQnpG9zcxY5Huyz0SY6EOII44/iunX kNTxAx9S9DVpVG/HFlMQzrKyeZSniBmx/loElW8W+HKE7Y+OpBYNGFbIKodgbtjzTpZa5W 4ud/rVq1kg951cPMXgWPh31ylOK/Qw6EiDR3ymSxhoGg+NSuo7ANfEx/JdR+Lk5VWnQG5m +nFNt9e708MPjxSBPe0e8m852iVj0Uetvz2/RSjs8udBvEk0ix8VLYnQBC9IUWXNsqoxSj jKGjTfIhnJ3ocv2aDtB1DA+l2E4lIThMkFRzA3F3iRbX0J1JnErO1Ejf3f9QLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dVRBc27d1zC61 for ; Mon, 15 Dec 2025 17:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id d5e4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 15 Dec 2025 17:00:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jessica Clarke Subject: git: 0e3963317e14 - stable/14 - kldxref: Don't warn and skip file if no relocations are found List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0e3963317e14ec86d0a597c91af36f043d583363 Auto-Submitted: auto-generated Date: Mon, 15 Dec 2025 17:00:08 +0000 Message-Id: <69403e98.d5e4.17f07100@gitrepo.freebsd.org> The branch stable/14 has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=0e3963317e14ec86d0a597c91af36f043d583363 commit 0e3963317e14ec86d0a597c91af36f043d583363 Author: Jessica Clarke AuthorDate: 2024-09-10 17:56:22 +0000 Commit: Jessica Clarke CommitDate: 2025-12-15 16:58:43 +0000 kldxref: Don't warn and skip file if no relocations are found This case is hit for the kernel itself on riscv64, and did not used to be checked. Since the code here can already handle missing Elf_Rel and/or Elf_Rela just delete the check. Reviewed by: jhb, imp Fixes: 0299afdff145 ("kldxref: Make use of libelf to be a portable cross tool") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46517 (cherry picked from commit 05996f453de2f2c7a03437a492d9d53831fccb2e) --- usr.sbin/kldxref/ef.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/usr.sbin/kldxref/ef.c b/usr.sbin/kldxref/ef.c index 77ddada946f2..975626e46046 100644 --- a/usr.sbin/kldxref/ef.c +++ b/usr.sbin/kldxref/ef.c @@ -364,11 +364,6 @@ ef_parse_dynamic(elf_file_t ef, const GElf_Phdr *phdyn) error = EFTYPE; goto out; } - if (rel_off == 0 && rela_off == 0) { - warnx("%s: no ELF relocation table found\n", ef->ef_name); - error = EFTYPE; - goto out; - } nsym = 0; for (i = 0; i < nshdr; i++) {