Date: Fri, 20 Nov 2020 11:16:13 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@freebsd.org>, Jilles Tjoelker <jilles@freebsd.org> Subject: Re: svn commit: r554893 - head/Mk/Scripts Message-ID: <20201120101613.6otci6zf3i7k77dn@aching.in.mat.cc> In-Reply-To: <dac04210-4580-d5ab-49e0-c1b501ea7ee7@FreeBSD.org> References: <202011111329.0ABDTqUD035770@repo.freebsd.org> <dac04210-4580-d5ab-49e0-c1b501ea7ee7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--bbo4icttjtn324gk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 19, 2020 at 11:41:57AM -0800, Bryan Drewery wrote: > On 11/11/2020 5:29 AM, Mathieu Arnold wrote: > > Author: mat > > Date: Wed Nov 11 13:29:52 2020 > > New Revision: 554893 > > URL: https://svnweb.freebsd.org/changeset/ports/554893 > >=20 > > Log: > > Add set pipefail in most framework scripts. > > =20 > > set pipefail changes the pipeline return status from being the return > > status of the last command to the last non 0 exit status of any comma= nd > > in the pipeline. This is needed to make sure all the commands in a > > pipeline did actually return a non 0 status and not only the last one. > > =20 > > PR: 250723 > > Exp-run by: antoine > > Reviewed by: bapt > > Approved by: bapt > > Differential Revision: https://reviews.freebsd.org/D27007 > >=20 > > Modified: > > head/Mk/Scripts/check-desktop-entries.sh (contents, props changed) > > head/Mk/Scripts/check-stagedir.sh (contents, props changed) > > head/Mk/Scripts/check-vulnerable.sh (contents, props changed) > > head/Mk/Scripts/check_leftovers.sh (contents, props changed) > > head/Mk/Scripts/checksum.sh (contents, props changed) > > head/Mk/Scripts/create-manifest.sh (contents, props changed) > > head/Mk/Scripts/depends-list.sh (contents, props changed) > > head/Mk/Scripts/desktop-categories.sh (contents, props changed) > > head/Mk/Scripts/dialog4ports.sh (contents, props changed) > > head/Mk/Scripts/do-depends.sh (contents, props changed) > > head/Mk/Scripts/do-fetch.sh (contents, props changed) > > head/Mk/Scripts/do-patch.sh (contents, props changed) > > head/Mk/Scripts/do-users-groups.sh (contents, props changed) > > head/Mk/Scripts/find-lib.sh (contents, props changed) > > head/Mk/Scripts/generate-symbols.sh (contents, props changed) > > head/Mk/Scripts/install-desktop-entries.sh (contents, props changed) > > head/Mk/Scripts/makesum.sh (contents, props changed) > > head/Mk/Scripts/plist_sub_sed_sort.sh (contents, props changed) > > head/Mk/Scripts/ports_env.sh (contents, props changed) > > head/Mk/Scripts/qa.sh (contents, props changed) > > head/Mk/Scripts/rust-compat11-canary.sh (contents, props changed) > > head/Mk/Scripts/smart_makepatch.sh (contents, props changed) > >=20 > > Modified: head/Mk/Scripts/check-desktop-entries.sh > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:24:31 2020 (= r554892) > > +++ head/Mk/Scripts/check-desktop-entries.sh Wed Nov 11 13:29:52 2020 (= r554893) > > @@ -4,6 +4,7 @@ > > # MAINTAINER: portmgr@FreeBSD.org > > =20 > > set -e > > +set -o pipefail > > =20 > > . "${dp_SCRIPTSDIR}/functions.sh" > > =20 > >=20 >=20 > This can prevent someone from upgrading from an unsupported release. The > workaround is simple enough so I think we should take it rather than > create burdens for people. >=20 > command set -o pipefail 2>/dev/null || : Ok, but, the point of unsupported releases is that they are not supported. The next sentence is very strange to write, and probably read. We only support supported releases. If you want to build ports on an unsupported release, you are on your own. If pipefail is not supported where you need to builds ports, then remove the lines on your ports tree, but we will not put support for unsupported releases in the FreeBSD ports tree. (Because, and I may repeat myself, we only support supported releases.) --=20 Mathieu Arnold --bbo4icttjtn324gk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl+3l2hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgKqig//aPJtKJ8u9v7CTqlWm1o/HbrTxEYQ5boOS+cd24TunwjDM//f0BcScZyH wVYtRIJpkgVU8vji+Y4PjQlIcmNRqFwICorWxRKciVHI2P79v+QqN3Bf1Rs3ul7j V8mrM9vICiJK/1C/GneSjQonlpWxp0ugbwlXRdMII0q5fvbfuhtrwxU/FnQvIO84 iLS7isgceaBIW+7U+r/viIYdFaYD4rqhpNq/NREtRTx767P9MIv/1hXtONX6Txnl K69LnzROHjZU7ZOFlrtesQYDNLOuv4/I9bo0S3yRsi+wotDoE7Cc3MLpFbw8WqgA 0+5YIemcF/MjwTRCxQByu4G4AflwG4lZ5xB7kIZHCfpV0r69JflivAFsCH6J5MNu pDFtLtPNUL1a/4uwzG0NtY5Nag1EORqDWxocwpn/e8fqC+j9CL0FyLu9yEtz9pMg eQS3mE6wmbozwZcTPiE4qsG2pSDt+iorzOQ8zNlvYzaBYJgBwbsB5UesecOOmONi kjsMB51zQPIuCwd4gp5vA8yzHG9J0PF1GTDLfJg+jlxwS2f84jVbn7UYU/zrDbAq FnEGCXN7icX0GZHphQ0vK1iJNTidFI8EgqQg7ZrK4xTw2rgZltJTZaUZl8SDPb2F +OzGNmZM0d1yP2QTWkJZgQxU+gbxZpCf2KtCjWjsgO4NOP2DvK0= =NXK+ -----END PGP SIGNATURE----- --bbo4icttjtn324gk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201120101613.6otci6zf3i7k77dn>