Date: Tue, 12 Apr 2011 14:57:26 +0200 From: Hans Petter Selasky <hselasky@freebsd.org> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r220558 - in head/sys: arm/econa dev/usb/controller mips/atheros mips/rmi Message-ID: <201104121457.26348.hselasky@freebsd.org> In-Reply-To: <4DA447F7.50104@freebsd.org> References: <201104120749.p3C7nBDQ014198@svn.freebsd.org> <4DA447F7.50104@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 12 April 2011 14:39:19 Nathan Whitehorn wrote: > On 04/12/11 02:49, Hans Petter Selasky wrote: > > Author: hselasky > > Date: Tue Apr 12 07:49:11 2011 > > New Revision: 220558 > > URL: http://svn.freebsd.org/changeset/base/220558 > > > > Log: > > We don't need to call EOWRITE4(sc, EHCI_USBINTR, 0) directly from each > > EHCI bus driver at detach, hence ehci_detach() does exactly this > > since r199718. > > Just so you're aware, there's also another EHCI driver in the tree at > /sys/powerpc/ps3/ehci_ps3.c. It might also need some modifications at > various points when you're cleaning up EHCI drivers. This driver doesn't have a detach method. The patches don't apply to this driver then. Should I add a detach method or is it superfluous? Thanks for noticing! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104121457.26348.hselasky>