From owner-svn-ports-head@FreeBSD.ORG Fri Apr 3 15:25:58 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F6804F5 for ; Fri, 3 Apr 2015 15:25:58 +0000 (UTC) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E2508891 for ; Fri, 3 Apr 2015 15:25:57 +0000 (UTC) Received: by obbec2 with SMTP id ec2so173990855obb.3 for ; Fri, 03 Apr 2015 08:25:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=YXWghRy/4x7MQaWzRsb37u4ZzWA7ai47wrSf0eTAA3M=; b=eAJR/kJ/nP1a+8ZHrxY8yQOwVfvcLapHnNBjeX6ftSPGBC/uL42Ycj05d6QHr4ONwd vAwabXes/DhHU6wvyrZukATuBvGNYHmWKWw8l1SFDLz/abrQmqfU9udy5slU0cTksPKg g+tPJdkeEleuyg/gaTp7VQQcel/qVYcFIRPp8Xh7HwN38YEZ++/i+7td7vCT3LUnhPoq 1jv1BpQm/pm/nfXslXh/MFyj1VkkSv4OIO1sd7TJ2sCU5bCLOVL6O6rZMHNpV3Pe7Hu+ C7jbo6LKQu/PKJ+o45JVWtD5pnkz3jJ3xCmSjzdsIz3WC3FuV3GXORxT+aA+cKZwEAcr G/LA== X-Gm-Message-State: ALoCoQlRoyYjS6ZOdKBUHvjRKz1SfqdNYQUD/UGvNseFVp1uEbX666cGu9Wn9Sk5WV2dl9Mu/md7 X-Received: by 10.60.84.144 with SMTP id z16mr3640235oey.32.1428074751285; Fri, 03 Apr 2015 08:25:51 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.202.61.139 with HTTP; Fri, 3 Apr 2015 08:25:31 -0700 (PDT) In-Reply-To: <20150403151746.GA13396@FreeBSD.org> References: <201504031232.t33CW7wi035371@svn.freebsd.org> <20150403151746.GA13396@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 3 Apr 2015 23:25:31 +0800 X-Google-Sender-Auth: NupjCU61V60xNZRBWR0Z2OZ4IbI Message-ID: Subject: Re: svn commit: r383112 - head/databases/postgresql94-server To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Bartek Rutkowski , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2015 15:25:58 -0000 On Fri, Apr 3, 2015 at 11:17 PM, Alexey Dokuchaev wrote: > On Fri, Apr 03, 2015 at 11:08:47PM +0800, Sunpoet Po-Chuan Hsieh wrote: > > Regarding the CPE PRs, though Shun submitted the patch as > "USES+=cpe", > > I would be grateful if you could use more tabs to have same indent with > > other lines. It needs 2 tabs in this case. > > +1000. I was hoping someone would finally speak up on this matter (so I > won't be blamed for nitpicking this time ;-) > > Also, in addition to bogus indentation, I don't see any need to use += vs. > just = . > > ./danfe > I forgot I mentioned that this commit is unnecessary in the followup of r381722. Though duplicate items in USES are harmless, we only need to add USES+=cpe for postgresql{84,91,92}-server/Makefile. % tail -1 postgresql*-server/Makefile ==> postgresql84-server/Makefile <== .include ==> postgresql90-server/Makefile <== .include "${.CURDIR}/../postgresql91-server/Makefile" ==> postgresql91-server/Makefile <== .include ==> postgresql92-server/Makefile <== .include ==> postgresql93-server/Makefile <== .include "${.CURDIR}/../postgresql92-server/Makefile" ==> postgresql94-server/Makefile <== .include "${.CURDIR}/../postgresql92-server/Makefile" % grep cpe postgresql*-server/Makefile postgresql90-server/Makefile:USES+= cpe postgresql91-server/Makefile:USES+= cpe postgresql92-server/Makefile:USES+= cpe postgresql93-server/Makefile:USES+= cpe postgresql94-server/Makefile:USES+= cpe Regards, sunpoet