From owner-freebsd-perl@FreeBSD.ORG  Thu Jul 29 07:03:57 2010
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: perl@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E7F00106566C;
	Thu, 29 Jul 2010 07:03:57 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (lefty.soaustin.net [66.135.55.46])
	by mx1.freebsd.org (Postfix) with ESMTP id C28138FC21;
	Thu, 29 Jul 2010 07:03:57 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id 06B768C0A7; Thu, 29 Jul 2010 02:03:57 -0500 (CDT)
Date: Thu, 29 Jul 2010 02:03:56 -0500
From: Mark Linimon <linimon@lonesome.com>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20100729070356.GA25380@lonesome.com>
References: <20100718223830.GA10338@lonesome.com>
	<4C43B4A5.5080104@FreeBSD.org> <4C44D01C.70704@p6m7g8.com>
	<alpine.BSF.2.00.1007192043010.1694@qbhto.arg>
	<4C451F06.8020106@p6m7g8.com>
	<alpine.BSF.2.00.1007192102470.1694@qbhto.arg>
	<4C453409.8000201@p6m7g8.com>
	<alpine.BSF.2.00.1007192254160.1725@qbhto.arg>
	<20100729041455.GA21455@lonesome.com>
	<alpine.BSF.2.00.1007282321490.1718@qbhto.arg>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.BSF.2.00.1007282321490.1718@qbhto.arg>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: jhell <jhell@DataIX.net>, skv@FreeBSD.org, ports@FreeBSD.org,
	perl@FreeBSD.org, portmgr@FreeBSD.org
Subject: Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12
	Mk/bsd.perl.mk)
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: maintainer of a number of perl-related ports
	<freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2010 07:03:58 -0000

On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote:
> When I asked you what was necessary to test this, you said all that was  
> necessary was to define _PERL_REFACTORING_COMPLETE.

And my memory slipped.

The explanation, however, was correct: the problem is that if you
unconditionally include bsd.perl.mk, everything works, and if you
conditionally include it, it doesn't.  If you didn't patch the code
that does the conditional include, then you didn't test for the
actual problem.

This is a case of believing the author and/or the documentation, and
not looking at the code.

I made a mistake; it was not intentional; I'm sorry.

mcl