Date: Thu, 11 Jul 2019 17:29:30 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238258] loader cant't find pool by guid Message-ID: <bug-238258-227-itBB8rUKBd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238258-227@https.bugs.freebsd.org/bugzilla/> References: <bug-238258-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238258 Kyle Evans <kevans@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tsoome@freebsd.org --- Comment #9 from Kyle Evans <kevans@freebsd.org> --- CC'ing tsoome@; partitionless disk setups were somewhat intentionally broken in r342151 [0] because they pose a number of problems (outlined in the commit message linked). loader/libsa built with the patch at [1] should workaround this, but more consideration needs to be made for loader handling these setups. [0] https://svnweb.freebsd.org/base?view=revision&revision=342151 [1] Index: stand/libsa/zfs/zfs.c =================================================================== --- stand/libsa/zfs/zfs.c (revision 349913) +++ stand/libsa/zfs/zfs.c (working copy) @@ -580,11 +580,10 @@ pa.fd = open(devname, O_RDONLY); if (pa.fd == -1) return (ENXIO); - /* - * We will not probe the whole disk, we can not boot from such - * disks and some systems will misreport the disk sizes and will - * hang while accessing the disk. - */ + /* Probe the whole disk */ + ret = zfs_probe(pa.fd, pool_guid); + if (ret == 0) + return (0); if (archsw.arch_getdev((void **)&dev, devname, NULL) == 0) { int partition = dev->d_partition; int slice = dev->d_slice; -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238258-227-itBB8rUKBd>