From owner-freebsd-current Tue Aug 25 19:34:15 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id TAA25785 for freebsd-current-outgoing; Tue, 25 Aug 1998 19:34:15 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ren.dtir.qld.gov.au (ns.dtir.qld.gov.au [203.108.138.66]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA25772 for ; Tue, 25 Aug 1998 19:34:06 -0700 (PDT) (envelope-from syssgm@dtir.qld.gov.au) Received: by ren.dtir.qld.gov.au; id MAA23293; Wed, 26 Aug 1998 12:33:00 +1000 (EST) Received: from ogre.dtir.qld.gov.au(167.123.8.3) by ren.dtir.qld.gov.au via smap (3.2) id xma023262; Wed, 26 Aug 98 12:32:44 +1000 Received: from atlas.dtir.qld.gov.au (atlas.dtir.qld.gov.au [167.123.8.9]) by ogre.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id MAA25287; Wed, 26 Aug 1998 12:32:44 +1000 (EST) Received: from nymph.dtir.qld.gov.au (nymph.dtir.qld.gov.au [167.123.10.10]) by atlas.dtir.qld.gov.au (8.8.5/8.8.5) with ESMTP id MAA10123; Wed, 26 Aug 1998 12:32:43 +1000 (EST) Received: from nymph.dtir.qld.gov.au (localhost.dtir.qld.gov.au [127.0.0.1]) by nymph.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id MAA06321; Wed, 26 Aug 1998 12:32:41 +1000 (EST) (envelope-from syssgm@nymph.dtir.qld.gov.au) Message-Id: <199808260232.MAA06321@nymph.dtir.qld.gov.au> To: Doug Rabson cc: "John S. Dyson" , freebsd-current@FreeBSD.ORG, syssgm@dtir.qld.gov.au Subject: Re: Serious bug in vm_page.h in current References: In-Reply-To: from Doug Rabson at "Tue, 25 Aug 1998 19:10:48 +0100" Date: Wed, 26 Aug 1998 12:32:40 +1000 From: Stephen McKay Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tuesday, 25th August 1998, Doug Rabson wrote: >On Tue, 25 Aug 1998, Stephen McKay wrote: > >> On Tuesday, 25th August 1998, Doug Rabson wrote: >> >> Purely on naming now, the new inline vm_object_set_flag() and friends are >> well named. The PAGE_BUSY and PAGE_WAKEUP macros, etc, should be similarly >> named inline functions. For example, vm_page_busy_add() and vm_page_wakeup(). >I chose the PAGE_XXX type names since they seemed to follow the existing >macros in vm_page.h. I am perfectly happy to change them to inline >functions with a similar naming convention to the ones in vm_object as >long as all of the other PAGE_XXX macros change at the same time. I was perhaps too brief. All the PAGE_XXX macros would have to change to be consistent (hopefully changed to inline functions at the same time). I had noticed that you were being consistent with existing naming, but the naming used in vm_object.h is clearly better. >The i/o count should certainly have a less confusing name. Indeed. I'm sure you will come up with a good one. Stephen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message