Date: Thu, 29 Dec 2022 00:26:01 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg@mail.gmail.com> In-Reply-To: <CAFDf7U%2BiEXKkpFkyjtN-wRa6N%2BNT1X5%2BLLqzZhv%2By-vjPsRAGA@mail.gmail.com> References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> <Y6ogXR2mFK%2BfqcH/@KGPE-D16> <CAFDf7U%2BT=4DQeoHeOY5UH_8hnYd1CujW=wgA25Nx9A6Wt5AN=A@mail.gmail.com> <Y6w6xrKKj42u1tem@KGPE-D16> <Y6xBgNjWEY5uMfBl@graf.pompo.net> <Y6xH0xp1pSr5NBiv@KGPE-D16> <CAFDf7U%2BiEXKkpFkyjtN-wRa6N%2BNT1X5%2BLLqzZhv%2By-vjPsRAGA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004a7b3b05f0ec8898 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (...) Got confused with that commit that have some months old. Current Makefile has: --- .if !exists(/usr/include/omp.h) USES+=3D compiler:c++14-lang USE_GCC=3D yes .else USES+=3D compiler:c++14-lang .endif --- And it should be corrected to: --- .if !exists(/usr/include/omp.h) USES+=3D compiler:gcc-c++11-lib .endif --- Is that ok? Sorry because I've got confused Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/2022 =C3= =A0(s) 23:59: > You have fixed it in > https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a= 2e745ed4293 > > I think I understand it better now > > Thanks > > Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 =C3= =A0(s) > 13:43: > >> It would and I was against removal of USES=3Dcompiler:openmp but it was >> done anyway without any regard for architectures that don't have libomp. >> >> On 22-12-28 14:15:44, Thierry Thomas wrote: >> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <pkubaj@anon= goth.pl> >> =C3=A9crivait : >> > >> >> If OpenMP is still necessary, then the best way would be: >> >> .if !exists(/usr/include/omp.h) >> >> USES+=3D compiler:gcc-c++11-lib >> >> .else >> >> USES+=3D compiler:c++14-lang >> >> .endif >> > >> >It would be great to re-add an argument "openmp" in Mk/Uses/compiler.mk >> >to put this kind of code at a central place. >> >-- >> >Th. Thomas. >> > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000004a7b3b05f0ec8898 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>(...)</div><div><br></div><div>Got confused with that= commit that have some months old.</div><div><br></div><div>Current Makefil= e has:</div><div>---</div><div>.if !exists(/usr/include/omp.h)<br>USES+=3D = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lang<br>USE_GCC=3D =C2=A0 = =C2=A0 =C2=A0 =C2=A0yes<br>.else<br>USES+=3D =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0compiler:c++14-lang<br>.endif</div><div>---</div><div>And it should b= e corrected to:</div><div>---</div><div>.if !exists(/usr/include/omp.h)<br> USES+=3D=C2=A0 compiler:gcc-c++11-<span class=3D"gmail-il">lib</span></div>= <div><span class=3D"gmail-il">.endif<br></span></div><div><span class=3D"gm= ail-il">---<br></span></div><div><span class=3D"gmail-il"><br></span></div>= <div><span class=3D"gmail-il">Is that ok?</span></div><div><span class=3D"g= mail-il">Sorry because I've got confused<br></span></div></div><br><div= class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Nuno Teixeira = <<a href=3D"mailto:eduardo@freebsd.org">eduardo@freebsd.org</a>> escr= eveu no dia quarta, 28/12/2022 =C3=A0(s) 23:59:<br></div><blockquote class= =3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg= b(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>You have fixed it in= <a href=3D"https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b= 6fc713121a2e745ed4293" target=3D"_blank">https://cgit.freebsd.org/ports/com= mit/?id=3Db02f812b43870dc615b6fc713121a2e745ed4293</a></div><div><br></div>= <div>I think I understand it better now</div><div><br></div><div>Thanks<br>= </div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_= attr">Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl" target=3D"_blan= k">pkubaj@anongoth.pl</a>> escreveu no dia quarta, 28/12/2022 =C3=A0(s) = 13:43:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0= px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">It would = and I was against removal of USES=3Dcompiler:openmp but it was<br> done anyway without any regard for architectures that don't have libomp= .<br> <br> On 22-12-28 14:15:44, Thierry Thomas wrote:<br> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <<a href= =3D"mailto:pkubaj@anongoth.pl" target=3D"_blank">pkubaj@anongoth.pl</a>>= =C3=A9crivait=C2=A0:<br> ><br> >> If OpenMP is still necessary, then the best way would be:<br> >> .if !exists(/usr/include/omp.h)<br> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:gcc-c++11-lib<br> >> .else<br> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:c++14-lang<br> >> .endif<br> ><br> >It would be great to re-add an argument "openmp" in Mk/Uses/<= a href=3D"http://compiler.mk" rel=3D"noreferrer" target=3D"_blank">compiler= .mk</a><br> >to put this kind of code at a central place.<br> >-- <br> >Th. Thomas.<br> </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr"><div dir= =3D"ltr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Co= mmitter (ports)</span></div></div> </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g= mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun= o Teixeira<br>FreeBSD Committer (ports)</span></div></div> --0000000000004a7b3b05f0ec8898--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg>