From nobody Fri Jun 26 21:37:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gn8Cw44gyz6hyl4 for ; Fri, 26 Jun 2026 21:37:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gn8Cw1bRFz3fZB for ; Fri, 26 Jun 2026 21:37:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782509868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nYiuy9yatkQSHvMD7fxHuytWprZ+U0IX9smyJx70yL8=; b=fuvGMt+jZgrcIyHRLy98311+jhBbWF8/06OHHlsHBJx7APZG2SEK2UnzemdXhactHzewdV evet287UINyJHPXvvSdmKXmd4Tduv5SkOarqtLpnbkGaH2JHsBz3QuLuYNSyi5ioMZftEP GG5vY2MLEzzR5bivC3FnMGFTh2xXjzAeF16gqpjTgid0IKa7gpFwMlziK04pfEWSlSNckQ YSkQ1CdJX92/RVvxtPzos9WLHtUAahmdSNz6m4PZKSDvYQz2F8Us/GmAYnqoHRD+M7DxTH 5SLbO3kLDJscHfqA7fr0JEk87M5gGjK6pWeS9gucvHp2BvupuSmZaCKuIKTSxg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782509868; a=rsa-sha256; cv=none; b=Vu9DUHRhO+CWsDVbjtn0Mp7Lxp1YtnRyq+hLBXXFWIeIDqdfhyjs4GFQSHT1BUZCtCdS9N 3jXfUJ18ACzLN0VAgmJIZpUVLjEhaY4jiai9l1fQ36cjEiP8/DPwqcx5MtkrEJEWGx9HnT Mjfznsax2+HWY+HbKWAgLKfREr6kgrmUcDZERfp+ok+glVmmGUD1r4iD9Iy/k2GPCZ8xM8 Tf0jPVG2Fw5nwD9a62Yl10xHL7zbgMB6PUHMwxtuoBTFdYl6aue5sRvCtwcHwjmtpU43PJ rSEwXQxLMqnZBPVSz0Rni2Kw5fr9UVMOh80Ww0swhj1I2SABAOS2tHwYxS01Bw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782509868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nYiuy9yatkQSHvMD7fxHuytWprZ+U0IX9smyJx70yL8=; b=hvv5pJk7sTBN/81yl6oCeDOq18C0OkKnf+Lv/WRveZVEUmkxdWnZO5/fJSRuGJ5vI1jvMQ gu03q8xXW3yGQKamD4hZQpVSkv6WdMTVzUUQJFp0LynSBzqZTW0A25WUjTVrMgjROZ/BY/ 2LXEPtC5xKSkQ5xonCVVShuaPnfUdiHSUvYmRzm+qnem1RU3fgDWJXTne5D24RTZZEXB/d dGfCIsjOGesvFJQh2chLHPrjJa5sTtEDUpjGf/OadEKPUJao+qj8GEukcmk27qEhDJhLqY FHG2uEry+lGjH9WdE+NT/hp34EZ89OMVy4HB5HVLt9wEDlb7DyDT4kxC3ZDLrg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gn8Cw0cCwzwL4 for ; Fri, 26 Jun 2026 21:37:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 23c64 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 21:37:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 8ea6d9f33ee3 - main - hwpstate_intel(4): Debug sysctl: Style List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8ea6d9f33ee3bb37b381d547517ae612ba1640db Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 21:37:48 +0000 Message-Id: <6a3ef12c.23c64.3cd8b8fe@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=8ea6d9f33ee3bb37b381d547517ae612ba1640db commit 8ea6d9f33ee3bb37b381d547517ae612ba1640db Author: Olivier Certner AuthorDate: 2026-06-26 14:03:51 +0000 Commit: Olivier Certner CommitDate: 2026-06-26 21:36:44 +0000 hwpstate_intel(4): Debug sysctl: Style Introduce 'error', set it to the result of rdmsr_safe() and use 'error' as the test expression. No functional change (intended). Fixes: 29b8220b179b ("hwpstate_intel: Use ipi instead of thread_lock + sched_bind") MFC after: 2 weeks Event: Halifax Hackathon 202606 Location: Dalhousie CS Faculty building Sponsored by: The FreeBSD Foundation --- sys/x86/cpufreq/hwpstate_intel.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/sys/x86/cpufreq/hwpstate_intel.c b/sys/x86/cpufreq/hwpstate_intel.c index 71f490a00bdc..b02d212653d3 100644 --- a/sys/x86/cpufreq/hwpstate_intel.c +++ b/sys/x86/cpufreq/hwpstate_intel.c @@ -157,18 +157,26 @@ static void get_cppc_regs_cb(void *args) { struct get_cppc_regs_data *const data = args; + int error; data->res = 0; - if (rdmsr_safe(MSR_IA32_PM_ENABLE, &data->enabled)) + error = rdmsr_safe(MSR_IA32_PM_ENABLE, &data->enabled); + if (error != 0) data->res |= HWP_ERROR_CPPC_ENABLE; - if (rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, &data->caps)) + + error = rdmsr_safe(MSR_IA32_HWP_CAPABILITIES, &data->caps); + if (error != 0) data->res |= HWP_ERROR_CPPC_CAPS; - if (rdmsr_safe(MSR_IA32_HWP_REQUEST, &data->request)) + + error = rdmsr_safe(MSR_IA32_HWP_REQUEST, &data->request); + if (error != 0) data->res |= HWP_ERROR_CPPC_REQUEST; if (data->sc->hwp_pkg_ctrl) { - if (rdmsr_safe(MSR_IA32_HWP_REQUEST_PKG, &data->request_pkg)) + error = rdmsr_safe(MSR_IA32_HWP_REQUEST_PKG, + &data->request_pkg); + if (error != 0) data->res |= HWP_ERROR_CPPC_REQUEST_PKG; } }