From owner-freebsd-ports@FreeBSD.ORG Tue May 26 17:56:54 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0CE571065677 for ; Tue, 26 May 2009 17:56:54 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id A6B018FC17 for ; Tue, 26 May 2009 17:56:53 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 9161 invoked by uid 399); 26 May 2009 17:56:46 -0000 Received: from localhost (HELO ?192.168.1.6?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 26 May 2009 17:56:46 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4A1C2D5B.8070708@FreeBSD.org> Date: Tue, 26 May 2009 10:56:43 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Andriy Gapon References: <4A1C1972.6050902@icyb.net.ua> <4A1C1A58.9020601@icyb.net.ua> In-Reply-To: <4A1C1A58.9020601@icyb.net.ua> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.ORG Subject: Re: portmaster overzealous on distfiles? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 17:56:55 -0000 On Tue, 26 May 2009, Andriy Gapon wrote: > on 26/05/2009 19:31 Andriy Gapon said the following: >> I run the following command to upgrade from audacious 1.5.* to >> 2.0.*: $ portmaster audacious\* FYI, the \* at the end of that is not necessary. If the command line argument doesn't match a specific port it is treated as a glob pattern. >> This starts to build three ports: audacious, audacious-plugins, >> audacious-skins. At the end of audacious upgrade portmaster asked >> me if I want to delete not only the older distfile of audacious >> but also about the newer one, and the one for audacious-skins. > > After the above upgrade I re-run the command again (forceful > upgrade, so to say) and, again, after upgrading audacious port > portmaster asked me if I want to delete new-and-only distfiles for > other two ports. If the various distfiles all start with audacious-* then portmaster will ask you about them. I have gone back and forth in my mind about hiding that code behind an option now that I have fairly effective mechanisms in place to handle distfile stuff without resorting to the glob matching. The reason I haven't done it yet is that cases like you describe are actually fairly rare, and easily overcome with a combination of the -D option and the --clean-distfiles option later on at your convenience. The course of action that I've basically settled on at this point is rather than actually asking you if you want to remove the glob-match distfiles to issue a suggestion to try the --clean-distfiles option at some point in the future, which seems like a happy medium to me. As soon as I get time to do it anyway. :) hope this helps, Doug