Date: Thu, 29 Dec 2022 02:52:22 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Nuno Teixeira <eduardo@freebsd.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <Y6zy1jzT1CBLSzDE@KGPE-D16> In-Reply-To: <CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg@mail.gmail.com> References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> <Y6ogXR2mFK%2BfqcH/@KGPE-D16> <CAFDf7U%2BT=4DQeoHeOY5UH_8hnYd1CujW=wgA25Nx9A6Wt5AN=A@mail.gmail.com> <Y6w6xrKKj42u1tem@KGPE-D16> <Y6xBgNjWEY5uMfBl@graf.pompo.net> <Y6xH0xp1pSr5NBiv@KGPE-D16> <CAFDf7U%2BiEXKkpFkyjtN-wRa6N%2BNT1X5%2BLLqzZhv%2By-vjPsRAGA@mail.gmail.com> <CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--v0wLhvsWberFI2bV Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yes, that is ok. On 22-12-29 00:26:01, Nuno Teixeira wrote: >(...) > >Got confused with that commit that have some months old. > >Current Makefile has: >--- >.if !exists(/usr/include/omp.h) >USES+=3D compiler:c++14-lang >USE_GCC=3D yes >.else >USES+=3D compiler:c++14-lang >.endif >--- >And it should be corrected to: >--- >.if !exists(/usr/include/omp.h) >USES+=3D compiler:gcc-c++11-lib >.endif >--- > >Is that ok? >Sorry because I've got confused > >Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/2022 =C3= =A0(s) >23:59: > >> You have fixed it in >> https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121= a2e745ed4293 >> >> I think I understand it better now >> >> Thanks >> >> Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 =C3= =A0(s) >> 13:43: >> >>> It would and I was against removal of USES=3Dcompiler:openmp but it was >>> done anyway without any regard for architectures that don't have libomp. >>> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <pkubaj@ano= ngoth.pl> >>> =C3=A9crivait : >>> > >>> >> If OpenMP is still necessary, then the best way would be: >>> >> .if !exists(/usr/include/omp.h) >>> >> USES+=3D compiler:gcc-c++11-lib >>> >> .else >>> >> USES+=3D compiler:c++14-lang >>> >> .endif >>> > >>> >It would be great to re-add an argument "openmp" in Mk/Uses/compiler.mk >>> >to put this kind of code at a central place. >>> >-- >>> >Th. Thomas. >>> >> >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >> > > >--=20 >Nuno Teixeira >FreeBSD Committer (ports) --v0wLhvsWberFI2bV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOs8tYwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydDJoP/iRFqTrfeo7VhbMZlCIr+kLewUX7q1xX1K+Pfez/z4LmNjeRwa89YVIn LWk9/3dFHg+a0WozbMnslWBqp/BJvCiDZALqEOlPPTdbmLMdObvepufItZpQdA1R XbBOFDaJlPBaJGzNzW3BLpU2Z+/6Od1s/7+rnquiZo5lol/CLrAmN9H7dUVB4Xac nt2ouMuYouOEbDuUttDaYMqy9/Rlc+fnkpLjSqe7fEJYmCwx8bc7/lHoNEEZmAj3 8X4tekstC/879dA4eoeiH6945YCnpkXYMXKSVY1h5MC6Gn4ryHeevTE+4pfegXYz l431BrQKgG5/jqGycXgzbwxYtNI4OgEodLZY0vQJXnIlYTZxkRyi3MYRmhs+rpjR dj/U44GIiKpu13pDChcL3kTQDZg95WvB2ijFSqK16N3aqVBsFe1oS3Tmp+4BiRap Vuqo35068Hup+ZgIWITy/qFWEasPP8gFENPVGzC0DUgahVQA/1eREC9RZnVB1Zyb Eg5GVdamXFrMbzoxOOe+SsJa/nnIfjtOwbuzf+JCLGeCIfMn+3YK6Je/ruW1+d78 8zRBxWSo7PbAgg9lcswVqYgAgJg7Z1MQikkB607xvq8hY3ukcg739VosAZzemzhP k51LV3qGE3pTR7XopDZcN2zrAyGY3UlvTp/5fD9ErFp82+70aCfq =SiSH -----END PGP SIGNATURE----- --v0wLhvsWberFI2bV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y6zy1jzT1CBLSzDE>