Date: Tue, 24 Mar 2020 06:16:44 +0000 (UTC) From: Baptiste Daroussin <bapt@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359267 - in head: . share/mk Message-ID: <d6724f56-682e-4c1f-bf77-2ad3774a7a66@localhost> In-Reply-To: <87469ad7-182c-1cd7-489c-e1d2cb60e4a8@FreeBSD.org> References: <202003240109.02O195Gs086052@repo.freebsd.org> <87469ad7-182c-1cd7-489c-e1d2cb60e4a8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
24 mars 2020 02:24:21 Bryan Drewery <bdrewery@FreeBSD.org>: > On 3/23/2020 6:09 PM, Emmanuel Vadot wrote: > > > Author: manu > > Date: Tue Mar 24 01:09:04 2020 > > New Revision: 359267 > > URL: https://svnweb.freebsd.org/changeset/base/359267 > > > > Log: > > bsd.lib.mk: Do not include bsd.incs.mk for INTERNALLIB > > > > If we're building an internal lib do not bother including bsd.incs.mk so we > > will not install the headers. > > This also "solves" a problem with pkgbase where a libXXX-development package > > is created and due to how packages are created we add a dependency to a > > libXXX package that doesn't exists. > > > > Reported by: pizzamig > > Reviewed by: pizzamig bapt emaste > > Differential Revision: https://reviews.freebsd.org/D24166 > > > > Modified: > > head/ObsoleteFiles.inc > > head/share/mk/bsd.lib.mk > > > > Modified: head/ObsoleteFiles.inc > > ============================================================================== > > --- head/ObsoleteFiles.inc Tue Mar 24 01:08:06 2020 (r359266) > > +++ head/ObsoleteFiles.inc Tue Mar 24 01:09:04 2020 (r359267) > > @@ -36,6 +36,11 @@ > > # xargs -n1 | sort | uniq -d; > > # done > > > > +# 20200323: INTERNALLIB don't install headers anymore > > +OLD_FILES+=/usr/include/libelftc.h > > +OLD_FILES+=/usr/include/libifconfig.h > > +OLD_FILES+=/usr/include/libpmcstat.h > > + > > > > lib/libelftc/Makefile:INCS= libelftc.h > lib/libifconfig/Makefile:INCSDIR= ${INCLUDEDIR} > lib/libifconfig/Makefile:INCS= libifconfig.h > lib/libpmcstat/Makefile:INCS= libpmcstat.h > > This commit seems incomplete or wrong due to the leftover logic. > > This is on purpose so if anyone wants to promote those from internallib to something else, they can They just have to remove INTERNALLIB Best regards, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d6724f56-682e-4c1f-bf77-2ad3774a7a66>