From owner-freebsd-ports@freebsd.org  Sat Feb  4 22:24:48 2017
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4913CD10DD
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Sat,  4 Feb 2017 22:24:48 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 95C601901;
 Sat,  4 Feb 2017 22:24:47 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from [192.168.60.81] (unknown [185.46.212.64])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id 288E53F530;
 Sat,  4 Feb 2017 17:24:37 -0500 (EST)
Date: Sat, 4 Feb 2017 23:24:33 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: John Marino <marino@freebsd.org>
cc: Matthias Andree <matthias.andree@gmx.de>, ports-committers@freebsd.org, 
 freebsd-ports <freebsd-ports@freebsd.org>
Subject: Re: svn commit: r432796 - in head/graphics: rawtherapee
 rawtherapee-devel
In-Reply-To: <9c122c71-bc24-0ed4-e671-be49ab06431b@marino.st>
Message-ID: <alpine.LSU.2.20.1702042323090.2253@anthias.pfeifer.com>
References: <201701291922.v0TJMlQE038923@repo.freebsd.org>
 <f2e8dfd9-3d5d-668a-47c3-f7f50b1b9917@gmx.de>
 <9c122c71-bc24-0ed4-e671-be49ab06431b@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Feb 2017 22:24:48 -0000

On Fri, 3 Feb 2017, John Marino wrote:
> AFAIK it's not documented, but it's been spoken here quite a few times 
> and the result was "try to be nice and if you must use OSVERSION, guard 
> it with OPSYS".  Anything else is a bug because OSVERSION only makes 
> sense with an exact value of OPSYS ("FreeBSD").

Would it make sense to add a check to portlint that every condition
(or practically probably line, considering "...\\\n..." as one line)
that has OSVERSION also has OPSYS?

Gerald