From owner-freebsd-ports@FreeBSD.ORG  Wed May 13 19:26:22 2015
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0B8C9774
 for <freebsd-ports@freebsd.org>; Wed, 13 May 2015 19:26:22 +0000 (UTC)
Received: from khavrinen.csail.mit.edu (khavrinen.csail.mit.edu
 [IPv6:2001:470:8b2d:1e1c:21b:21ff:feb8:d7b0])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "khavrinen.csail.mit.edu", Issuer "Client CA" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id BDDEA1AB3
 for <freebsd-ports@freebsd.org>; Wed, 13 May 2015 19:26:21 +0000 (UTC)
Received: from khavrinen.csail.mit.edu (localhost [127.0.0.1])
 by khavrinen.csail.mit.edu (8.14.9/8.14.9) with ESMTP id t4DJQJ91003128
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256
 verify=FAIL CN=khavrinen.csail.mit.edu issuer=Client+20CA);
 Wed, 13 May 2015 15:26:19 -0400 (EDT)
 (envelope-from wollman@khavrinen.csail.mit.edu)
Received: (from wollman@localhost)
 by khavrinen.csail.mit.edu (8.14.9/8.14.9/Submit) id t4DJQIlL003125;
 Wed, 13 May 2015 15:26:18 -0400 (EDT) (envelope-from wollman)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <21843.42330.419411.175289@khavrinen.csail.mit.edu>
Date: Wed, 13 May 2015 15:26:18 -0400
From: Garrett Wollman <wollman@csail.mit.edu>
To: fv@moov.de, mat@freeebsd.org
Cc: freebsd-ports@freebsd.org
Subject: net-mgmt/p5-Cflow silently broken
X-Mailer: VM 7.17 under 21.4 (patch 22) "Instant Classic" XEmacs Lucid
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (khavrinen.csail.mit.edu [127.0.0.1]); Wed, 13 May 2015 15:26:19 -0400 (EDT)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2015 19:26:22 -0000

net-mgmt/p5-Cflow has been silently broken for some time, and I'm not
sure how properly to fix it.

When the port's configure phase runs, it correctly determines that it
should use OSU flow-tools, according to its own output.  However, this
does not make it into the generated Makefile, which should include
both "-DOSU" and "-I/usr/local/include" in CCFLAGS.  When -DOSU is not
defined for compilation, the module compiles successfully but to a
non-working state that doesn't actually invoke the flow-tools library
-- it treats the input file like raw cflow data (which it isn't).

This used to work (in recent memory).  I'm not sure what broke it, but
I suspect it was mat@'s change in r373901.  I've temporarily worked
around the problem (by building a package manually) but that will
break the next time Perl gets updated.

-GAWollman