From owner-freebsd-current@freebsd.org Thu Oct 17 19:53:53 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9712215C576; Thu, 17 Oct 2019 19:53:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vKc02ck5z4dfr; Thu, 17 Oct 2019 19:53:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x843.google.com with SMTP id t20so5377848qtr.10; Thu, 17 Oct 2019 12:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qowJUb7L7c2fZqsR+0mJEkhN3Qr8YbgQBbcw7tN4XxU=; b=qpV8g6jQeP1KPYujHbSiTFPpbmSg2mUX7WuxAWWvuwNTYqsuuXoOta+zATcAOlmRnv b3U8uZVwAe5r74xge+rD+tGXGwXshiR+s4nABPl6xEokIHg34M5Hny8bhrcS44m2Hnt2 bErdXpPw9+Am7e13AUz2spz/DKVN1PAqgFAEl0WYhPau7g5KvnunMVSiTQ0LEhAV7ERC GXzFkeSaF0jFJR0nKU6avJnmJnS5jJ2ilIg9ZgCxYCIRlTmglCN7vQJJ+M9fxKeE4Ln7 BCQd8WuCeHuk/b4BWARUTHctqOEbdAvc0bblvM4x2idsijIQVu1ac2nE/pYIMKeKENk2 24tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=qowJUb7L7c2fZqsR+0mJEkhN3Qr8YbgQBbcw7tN4XxU=; b=bWbEXj3ngUsh4ueeno6S/SjcRk0C7ug661lJZ5oyMax9WYHyE83gmd6Kb6T+sO3M9s YGbnXI7Q3lBCziKUuEWtPYlrIxQb8SHLYs4Tn/Rk+r/ByY2mKbp4cFyLVA5GzAFZ/l0/ CCe02YkCjsP252E4mDnMY8KeQblL88Hs+Xrth9C47xeitcDGI9AkBtNDVUW4Ah6CXkhG R9WoCGHPC6T5M/Qj5aVP3Y2kAkgfJyfu5qlVMgCEjElF2ATnRpwHr7WM91pQziq5tTfY 8Ynb1t6u0m1DEI5G3EEImEK+FiBs0GYoQlX1OC0lWRrznJS3MNTXurMc/IKpiGsx5fRp 9ZyQ== X-Gm-Message-State: APjAAAU/VzCWWrTjoVhUsni68L0YHRZpBV8DoH3KTdZ9ccZVUP8hVdr1 8zAjAzR1hyu/Ur2mPRUcoxI= X-Google-Smtp-Source: APXvYqzynA9z/rPUM/9wY1VoLp1unmHOWrIcbfTYWo1NE/dxq+Spotasq4zPXNL8/GPFK7YcApIe1Q== X-Received: by 2002:a0c:fc10:: with SMTP id z16mr5889110qvo.2.1571342030953; Thu, 17 Oct 2019 12:53:50 -0700 (PDT) Received: from raichu (toroon0560w-lp130-05-69-158-183-252.dsl.bell.ca. [69.158.183.252]) by smtp.gmail.com with ESMTPSA id d133sm2435182qkg.31.2019.10.17.12.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 12:53:49 -0700 (PDT) Sender: Mark Johnston Date: Thu, 17 Oct 2019 15:53:47 -0400 From: markj@freebsd.org To: Niclas Zeising Cc: Neel Chauhan , Mateusz Guzik , Evilham , FreeBSD Current , owner-freebsd-current@freebsd.org Subject: Re: DRM-current-kmod is still a problem at r353339 Message-ID: <20191017195347.GB6447@raichu> References: <7ca3b30a-81f6-f79d-1486-7fd29765646f@acm.org> <99c89ca0-462c-f4c7-fa07-6f61e9d39d66@acm.org> <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bb2e410-51dd-bc3f-7660-41a4683551b3@daemonic.se> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46vKc02ck5z4dfr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qpV8g6jQ; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::843 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[freebsd]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_NO_DN(0.00)[]; IP_SCORE(-0.41)[ip: (2.55), ipnet: 2607:f8b0::/32(-2.47), asn: 15169(-2.10), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 19:53:53 -0000 On Thu, Oct 17, 2019 at 03:03:51PM +0200, Niclas Zeising wrote: > On 2019-10-16 18:57, Neel Chauhan wrote: > > While drm-current-kmod worked for a little while, it broke with r353645. > > > > https://i.imgur.com/Q5nYZf2.jpg > > > > I'm using the same HP Spectre that I used earlier (where it worked and > > where it panicked). > > > > That commit looks unrelated, it touches the wbwd and superio drivers, > nothing else. Any chance you can bisect exactly which revision that > caused the new issues? I believe it was the recent work on the vm page busy state, r353539 specifically. This patch should fix it; we don't yet have a __FreeBSD_version number bump on which to gate the patch. diff --git a/linuxkpi/gplv2/src/linux_page.c b/linuxkpi/gplv2/src/linux_page.c index e2b85c45c..060ae85ed 100644 --- a/linuxkpi/gplv2/src/linux_page.c +++ b/linuxkpi/gplv2/src/linux_page.c @@ -239,7 +239,7 @@ retry: page = vm_page_lookup(devobj, i); if (page == NULL) continue; - if (vm_page_sleep_if_busy(page, "linuxkpi")) + if (!vm_page_busy_acquire(page, VM_ALLOC_WAITFAIL)) goto retry; cdev_pager_free_page(devobj, page); }