From owner-svn-src-head@FreeBSD.ORG Wed Jan 19 00:45:49 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F47B106566B; Wed, 19 Jan 2011 00:45:49 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 16DDA8FC08; Wed, 19 Jan 2011 00:45:47 +0000 (UTC) Received: by wwf26 with SMTP id 26so243945wwf.31 for ; Tue, 18 Jan 2011 16:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=z1xlx1to1Ko/o5reP9YWHSL3skhql2SaSl5u82E6CEw=; b=ROf2ok7lkFMiCHIhLodDgjaooex79oaUB18nnBVL4yTO0T5NjXf68c4baENr2fSYzP 3u0rhs/jnMsnSdDKwz58Px4qCPDKoC/2bnh2CoSS/duJ/rvjV4ASwVZvZ/R1Z4/zX9WY R2d7GJC+is62EnreDjD6JILk40ZWlkV/fSk+Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=A69sujThupSUFAwp+B6cp9wc1q9ka5o1zOYF4YNYH+wbrtszG8zDid2DgDqUe8q9iC iZz+gZNYqd0vT4bj33IJ/xYRTFxugddpwi1Kiz9S+aPtrgcG9/Yj6r7KVVetoj5Nc8lk dYGqdiy0Cc+eACbAZJONUwjty17jETHV9QH8M= MIME-Version: 1.0 Received: by 10.216.78.146 with SMTP id g18mr34859wee.1.1295397946943; Tue, 18 Jan 2011 16:45:46 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.254.226 with HTTP; Tue, 18 Jan 2011 16:45:46 -0800 (PST) In-Reply-To: References: <201101182118.p0ILIWA4052343@svn.freebsd.org> <4D3631DE.8040408@FreeBSD.org> Date: Tue, 18 Jan 2011 16:45:46 -0800 X-Google-Sender-Auth: IEuucY-dUo5NI02h-xZCens3UjI Message-ID: From: Garrett Cooper To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Jilles Tjoelker , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217557 - in head: bin/sh tools/regression/bin/sh/execution X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jan 2011 00:45:49 -0000 On Tue, Jan 18, 2011 at 4:43 PM, Garrett Cooper wrote= : > On Tue, Jan 18, 2011 at 4:35 PM, Doug Barton wrote: >> On 01/18/2011 14:33, Garrett Cooper wrote: >>> >>> On Tue, Jan 18, 2011 at 1:18 PM, Jilles Tjoelker >>> =A0wrote: >>>> >>>> Author: jilles >>>> Date: Tue Jan 18 21:18:31 2011 >>>> New Revision: 217557 >>>> URL: http://svn.freebsd.org/changeset/base/217557 >>>> >>>> Log: >>>> =A0sh: Fix signal messages being sent to the wrong file sometimes. >>>> >>>> =A0When a foreground job exits on a signal, a message is printed to st= dout >>>> =A0about this. The buffer was not flushed after this which could resul= t in >>>> the >>>> =A0message being written to the wrong file if the next command was a >>>> builtin >>>> =A0and had stdout redirected. >> >> Does this mean that portmaster is going to stop printing those !*@%$@(# >> "Terminated" messages that I have never been able to figure out how to g= et >> rid of, or am I just a loser? :) > > =A0 =A0Don't know. I noticed it because the posix testsuite has a program > that traps SIGALRM (system/OS dependent signal number) for the purpose > of watchdog'ing testcases so they don't hang. So it was doing > something like this: > > $ sh > $ python -c 'import os, signal; os.kill(0, signal.SIGALRM)' >/dev/null > 2>&1; echo $? > foo; echo "FOO:"; cat foo > FOO: > Alarm clock > 142 > $ > > =A0 =A0I would expect FOO: to follow Alarm clock, not precede it. > =A0 =A0Whether or not this fixes portmaster, I dunno... try running bash > or dash instead of /bin/sh to see whether or not the `problem' still > occurs. > HTH, > -Garrett > > PS Shells printing out Terminated, Alarm clock, etc is in the POSIX spec = IIRC. One other note -- the workaround for the above issue I discovered was to capture $? in a local variable and then echo it out the value of the local variable to a file. You may or may not be able to implement the same workaround *shrugs*. Thanks, -Garrett