From owner-svn-src-all@freebsd.org  Fri Feb 23 20:25:00 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9EAE3F1ADA5
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Fri, 23 Feb 2018 20:25:00 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2859676D44
 for <svn-src-all@freebsd.org>; Fri, 23 Feb 2018 20:24:59 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 863d74ce-18d7-11e8-b951-f99fef315fd9
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id 863d74ce-18d7-11e8-b951-f99fef315fd9;
 Fri, 23 Feb 2018 20:24:18 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w1NKOpOd067544;
 Fri, 23 Feb 2018 13:24:51 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1519417491.91697.193.camel@freebsd.org>
Subject: Re: svn commit: r329866 - head/sys/cam
From: Ian Lepore <ian@freebsd.org>
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Fri, 23 Feb 2018 13:24:51 -0700
In-Reply-To: <201802231606.w1NG6t45013919@repo.freebsd.org>
References: <201802231606.w1NG6t45013919@repo.freebsd.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2018 20:25:00 -0000

On Fri, 2018-02-23 at 16:06 +0000, Warner Losh wrote:
> -static inline int
> +static inline bool
>  cam_iosched_has_flagged_work(struct cam_iosched_softc *isc)
>  {
>         return !!(isc->flags & CAM_IOSCHED_FLAG_WORK_FLAGS);
>  }

There should be no need for the ugly !! here, conversion to bool in C99
is like it is for c++, it converts to zero if the expression being
converted has a value of zero, or to one otherwise.

-- Ian