From owner-freebsd-current@freebsd.org Mon Jan 13 14:36:04 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30EBD225BE1 for ; Mon, 13 Jan 2020 14:36:04 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47xGNg1h8gz4ZMC; Mon, 13 Jan 2020 14:36:03 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x436.google.com with SMTP id y17so8828504wrh.5; Mon, 13 Jan 2020 06:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HzHYmvJXhLFNHU+HHI0tJiogl3c1dFwt+JTilNaIQVE=; b=ZyKhO5fu5f3rT7YAfH9DsA4vkLsTFFdHrl0kLHAVfL+BKJh1sweFNgUAPmEs64IPwa LST/q8Ysa5/efM+pMJbyMIuiNtIx2f11n7CShx52d110x2PlaIxqN1g8/0wQeyqEcyHo X4wW+m1lLt22ZhY/6XRjxJrpdsEdXBX8DouMCfEyknXrWC3YxBufNJfnp5rX7T7kkpO0 +R+INckzDtq0ILGr7q3YjP/9NprUZGY6WU+pzsvRmyKCBTle0uMxxHuSTTBGY9dyCxtn ZIdfhiUiNXspWmlkdcaQAyzWWPiW7oXafqv6+34usf3GO6I1L02HGLzkSgvlPHzUSTY6 OMvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HzHYmvJXhLFNHU+HHI0tJiogl3c1dFwt+JTilNaIQVE=; b=fG05CN95QtcAj8mOxGH5qIHS6F5vU8ZWUL061qRMY4C7phCS7iPCbtLK6hiZQg06Gs pn2272c67b54rdTr0SUyX1gR3ITCOByJGFOO2RoB8SqlgUCDHL0pQ1xVRNHcb/+Cd+Um COZlbvmEjJ8jh8lQ5FL5kgRWwh8IrZk2vQ2yWtET5ek6QbtKLZLA5btG9sEpk6M6vbax ZmeC7IMUE3N2gZU/M0iG+BFMSEQvdcKEc6QmqE6gIhHmyQXUBPkBr1a5eKa0za7qb8Z/ RIreZ5G21eIZadIUq5+Lp55p3EMp2kROHUEQ87U2C03DiTlj5CB0S9Ai7VzGIxlO84QS oOUg== X-Gm-Message-State: APjAAAUDbM8mnbhCn6QAWOLoSQCU/qIqCaJ869LWVogofUAZVo4h1xnn NzIu9oc720aoEK795M407TWe7BDgV81ovuUR7kCV1g== X-Google-Smtp-Source: APXvYqzeRh3dGilJgf5M7ZYbll3EdexwgeMPKSBFk70gRzaVdkRbaZptTCyjGEV8UqjEY9DOlz0EbpbmIe8+PmHlTZQ= X-Received: by 2002:adf:d0c1:: with SMTP id z1mr19393880wrh.371.1578926161511; Mon, 13 Jan 2020 06:36:01 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5d:6b02:0:0:0:0:0 with HTTP; Mon, 13 Jan 2020 06:36:01 -0800 (PST) In-Reply-To: References: <943895765.5663.1578892204856.JavaMail.jenkins@jenkins.ci.freebsd.org> From: Mateusz Guzik Date: Mon, 13 Jan 2020 15:36:01 +0100 Message-ID: Subject: Re: FreeBSD-head-amd64-test - Build #13912 (r356671) - Failure To: Li-Wen Hsu Cc: Jeff Roberson , freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47xGNg1h8gz4ZMC X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ZyKhO5fu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::436 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (-9.12), ipnet: 2a00:1450::/32(-2.60), asn: 15169(-1.84), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[6.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2020 14:36:04 -0000 Fixed in r356683. On 1/13/20, Mateusz Guzik wrote: > On 1/13/20, Li-Wen Hsu wrote: >> On Mon, Jan 13, 2020 at 1:10 PM wrote: >>> >>> FreeBSD-head-amd64-test - Build #13912 (r356671) - Failure >>> >>> Build information: >>> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/ >>> Full change log: >>> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/changes >>> Full build log: >>> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/console >>> >>> Status explanation: >>> "Failure" - the build is suspected being broken by the following changes >>> "Still Failing" - the build has not been fixed by the following changes >>> and >>> this is a notification to note that these changes have >>> not been fully tested by the CI system >>> >>> Change summaries: >>> (Those commits are likely but not certainly responsible) >>> >>> 356671 by mjg: >>> ufs: use lazy list instead of active list for syncer >>> >>> Quota code is temporarily regressed to do a full vnode scan. >>> >>> Reviewed by: jeff >>> Tested by: pho (in a larger patch, previous version) >>> Differential Revision: https://reviews.freebsd.org/D22996 >>> >>> 356670 by mjg: >>> vfs: add per-mount vnode lazy list and use it for deferred inactive + >>> msync >>> >>> This obviates the need to scan the entire active list looking for vnodes >>> of interest. >>> >>> msync is handled by adding all vnodes with write count to the lazy list. >>> >>> deferred inactive directly adds vnodes as it sets the VI_DEFINACT flag. >>> >>> Vnodes get dequeued from the list when their hold count reaches 0. >>> >>> Newly added MNT_VNODE_FOREACH_LAZY* macros support filtering so that >>> spurious locking is avoided in the common case. >>> >>> Reviewed by: jeff >>> Tested by: pho (in a larger patch, previous version) >>> Differential Revision: https://reviews.freebsd.org/D22995 >>> >>> 356669 by mjg: >>> ufs: add a setter for inode i_flag field >>> >>> This will be used later to add vnodes to the lazy list. >>> >>> Reviewed by: kib (previous version), jeff >>> Tested by: pho (in a larger patch) >>> Differential Revision: https://reviews.freebsd.org/D22994 >> >> Hi Mateusz, >> >> I suspect these changes might have something to do about panic of i386 >> and amd64 in testing: > > I'm on it. > >> >> root@:/usr/tests # cd /usr/tests/usr.sbin/makefs/ >> root@:/usr/tests/usr.sbin/makefs # kyua debug >> makefs_cd9660_tests:o_flag_rockridge_dev_nodes >> VNASSERT failed >> 0xfffff8000f24a1e8: type VCHR >> usecount 1, writecount 0, refcount 1 rdev 0 >> flags () >> VI_LOCKed lock type ufs: SHARED (count 1) >> nlink=1, effnlink=1, size=0, extsize 0 >> generation=73c32c64, uid=0, gid=0, flags=0x0 >> ino 117778, on dev gpt/rootfs >> panic: ffs_unlock_debug: modified vnode (420) not on lazy list >> cpuid = 1 >> time = 1578910603 >> KDB: stack backtrace: >> db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame >> 0xfffffe0038a70fd0 >> vpanic() at vpanic+0x185/frame 0xfffffe0038a71030 >> panic() at panic+0x43/frame 0xfffffe0038a71090 >> ffs_unlock_debug() at ffs_unlock_debug+0xa5/frame 0xfffffe0038a710c0 >> lookup() at lookup+0xd26/frame 0xfffffe0038a71160 >> namei() at namei+0x4d8/frame 0xfffffe0038a71250 >> kern_fchmodat() at kern_fchmodat+0x92/frame 0xfffffe0038a71380 >> amd64_syscall() at amd64_syscall+0x2d6/frame 0xfffffe0038a714b0 >> fast_syscall_common() at fast_syscall_common+0x101/frame >> 0xfffffe0038a714b0 >> --- syscall (15, FreeBSD ELF64, sys_chmod), rip = 0x8003ba95a, rsp = >> 0x7fffffffe758, rbp = 0x7fffffffe7e0 --- >> KDB: enter: panic >> [ thread pid 1393 tid 100092 ] >> Stopped at kdb_enter+0x37: movq $0,0x1084396(%rip) >> db:0:kdb.enter.panic> show pcpu >> cpuid = 1 >> dynamic pcpu = 0xfffffe00887a7d80 >> curthread = 0xfffff8000f25a000: pid 1393 tid 100092 critnest 1 >> "bsdtar" >> curpcb = 0xfffff8000f25a4f0 >> fpcurthread = 0xfffff8000f25a000: pid 1393 "bsdtar" >> idlethread = 0xfffff800033976e0: tid 100004 "idle: cpu1" >> self = 0xffffffff82211000 >> curpmap = 0xfffff80003e35120 >> tssp = 0xffffffff82211384 >> rsp0 = 0xfffffe0038a71580 >> kcr3 = 0x800000000f2ab405 >> ucr3 = 0x800000000f287c05 >> scr3 = 0xf287c05 >> gs32p = 0xffffffff82211404 >> ldt = 0xffffffff82211444 >> tss = 0xffffffff82211434 >> tlb gen = 889 >> curvnet = 0 >> spin locks held: >> db:0:kdb.enter.panic> >> >> full log: >> https://ci.freebsd.org/job/FreeBSD-head-i386-test/8051/consoleFull >> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/13912/consoleFull >> >> test image: >> https://artifact.ci.freebsd.org/snapshot/head/r356671/i386/i386/disk-test.img.xz >> https://artifact.ci.freebsd.org/snapshot/head/r356671/amd64/amd64/disk-test.img.xz >> >> Can you help check this? Thanks. >> >> Best, >> Li-Wen >> > > > -- > Mateusz Guzik > -- Mateusz Guzik