Date: Mon, 19 Dec 2016 12:20:09 -0700 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@bsdimp.com>, Ravi Pokala <rpokala@mac.com> Cc: Sepherosa Ziehau <sepherosa@gmail.com>, Dimitry Andric <dim@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r310171 - head/sys/sys Message-ID: <1482175209.48539.9.camel@freebsd.org> In-Reply-To: <CANCZdfoN_NNsU2bW2mvLifSCoNhYj-XNvNYLosMsbmnbG9JfYQ@mail.gmail.com> References: <201612161949.uBGJnMol059217@repo.freebsd.org> <CAMOc5cw8cBUN5UZjcRJ-vM5WE0vmD2AGDZ-raKTraFz7LBR2hg@mail.gmail.com> <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> <CANCZdfoN_NNsU2bW2mvLifSCoNhYj-XNvNYLosMsbmnbG9JfYQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2016-12-19 at 11:58 -0700, Warner Losh wrote: > On Mon, Dec 19, 2016 at 1:39 AM, Ravi Pokala <rpokala@mac.com> wrote: > > > > -----Original Message----- > > > > > > From: <owner-src-committers@freebsd.org> on behalf of Sepherosa > > > Ziehau <sepherosa@gmail.com> > > > Date: 2016-12-18, Sunday at 23:02 > > > To: Dimitry Andric <dim@freebsd.org> > > > Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn > > > -src-head@freebsd.org> > > > Subject: Re: svn commit: r310171 - head/sys/sys > > > > > > The following patch unbreaks the LINT builds on amd64 for me > > > after this commit: > > > https://people.freebsd.org/~sephe/geom_sscanf.diff > > Wouldn't it be better to use the SCN macros? > Are there other precedence for avoiding the SCN macros in the tree as > well, or is this new art? > > Warner There was another commit recently the fixed the same kind of scanf error by making the variable fit the scanf type (changing uint64_t to an explicit long long unsigned, iirc). I don't know if that alone counts as a precedent, but IMO it's a more palatible fix than the SCN/PRI ugliness. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1482175209.48539.9.camel>