From owner-cvs-doc@FreeBSD.ORG  Tue Jul 17 14:46:22 2007
Return-Path: <owner-cvs-doc@FreeBSD.ORG>
X-Original-To: cvs-doc@freebsd.org
Delivered-To: cvs-doc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F3DD616A400
	for <cvs-doc@freebsd.org>; Tue, 17 Jul 2007 14:46:21 +0000 (UTC)
	(envelope-from chinsan.tw@gmail.com)
Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.247])
	by mx1.freebsd.org (Postfix) with ESMTP id B2D2813C481
	for <cvs-doc@freebsd.org>; Tue, 17 Jul 2007 14:46:21 +0000 (UTC)
	(envelope-from chinsan.tw@gmail.com)
Received: by an-out-0708.google.com with SMTP id c14so362137anc
	for <cvs-doc@freebsd.org>; Tue, 17 Jul 2007 07:46:21 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=rXdiieeRimWN2hCY4aE7iNIVw0pY8dQrKhv4v7f8NVb1YYx+7h56rnluFO2nbW9M/gj5zsMWUfD+IyLUP9fs5/X0DuSqFpXIbrsfPpPiOVEmmxc95zqZwN2D7UvdNOffQiEBWHEplONJvmTTyOku5IZGaC31SzUwWgXcbOWoJeM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=KsyhQjgu0eaBbMmgnLwgkMpqcOwyIF0vvQC5whSIIO2mgRLljU30wjIPnj/8Ejs4Z1amthx2oAcNLGAHRPZfC7NW9y83iXijFnD/GkYw9TJ3iXKWEfR2B8qSM08lZgtnuTjKdq0ZvH9UK5VhhPRkw0glj/goy5Yy0EcqnEA7l1Q=
Received: by 10.100.133.9 with SMTP id g9mr243126and.1184683580448;
	Tue, 17 Jul 2007 07:46:20 -0700 (PDT)
Received: by 10.100.119.4 with HTTP; Tue, 17 Jul 2007 07:46:20 -0700 (PDT)
Message-ID: <1f27304c0707170746j53a273c3n9e5b34612098dd79@mail.gmail.com>
Date: Tue, 17 Jul 2007 22:46:20 +0800
From: chinsan <chinsan.tw@gmail.com>
To: "Florent Thoumie" <flz@freebsd.org>
In-Reply-To: <469B7CE0.8030409@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070716135602.7EF3816A49C@hub.freebsd.org>
	<469B7CE0.8030409@FreeBSD.org>
Cc: cvs-doc@freebsd.org
Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics
	chapter.sgml
X-BeenThere: cvs-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the doc and www trees <cvs-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-doc>
List-Post: <mailto:cvs-doc@freebsd.org>
List-Help: <mailto:cvs-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-doc>,
	<mailto:cvs-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2007 14:46:22 -0000

On 7/16/07, Florent Thoumie <flz@freebsd.org> wrote:
> Chin-San Huang wrote:
> > chinsan     2007-07-16 13:55:59 UTC
> >   - According to the module(9) man page, the return value for
> >     unrecognized values is EOPNOTSUPP, not EINVAL.
>
> Using both EINVAL and EOPNOTSUPP makes sense to me. In the arch-handbook
> code snippet we return EOPNOTSUPP whether what is MOD_QUIESCE or an
> invalid value.
>
> I understand it's done that way for simplicity's sake (instead of adding
> a case statement for unsupported operations and default to return
> EINVAL), but there's an inconsistency with module(9).
>
> It currently says:
>
> "The module should return EOPNOTSUPP for unrecognized values of what"
>
> Maybe something like the following would be better:
>
> "The module should return EOPNOTSUPP for unsupported and unrecognized
> values of what."

Hi,
Please feel free to document that part. :)

- chinsan