From nobody Thu Jul 2 09:34:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4grWv65wmYz6kPGR for ; Thu, 02 Jul 2026 09:34:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4grWv63wQ8z3KqT for ; Thu, 02 Jul 2026 09:34:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782984898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fC/RYjpVF9hCAKviZb2lPR/GhKvwSh5WsrHkaxcN1Yc=; b=MJkzz0cLwT2WxiMhrE1jWMK7lXyFMrzPg85aZmdZfOihwj56yztBDwnmvSDkxXfw31VKka dtpi/wLJGYtIFe1KS+hnJubourIexGLv7AH1/QSsidRmWonJIZ9magjNnAp+aa8Tu2C0QN ygamUUhvSa7VBa6AbJ/fbcoO2tys54nmBb2T2of2ojx0ia0W9tOxrRsHAxHrOgfeBc9lER N7Ce0uT9kPTA5Ji5ZeQzcqO6YCLfV+vjXL1ITij9BjFd1scOFh/pG04kQuiiyIk0UUrF6u bmwEZE+sE5837sJoYvgdxJeRaDSq2LssiekM2ilO6Y4vzUNjsFF6GgddufioZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782984898; a=rsa-sha256; cv=none; b=rhltZmdjEUIOjmuJXxyZ39TSXAdmMREZaqW8u6Wth13sA1PbePbHALFBvJsMozl7Ruu/iV Pv5oH53I6CAdaReiwMPy9tu+MrQHFUUwmDeAYa3+Hd0iZAOH8Ew0+b3PgQwfXI8JfZS94V 9YNRPgplW++nzPQd307TbcK8bYnleiJkv8WgcFBBb9gR7nZXzHXCBD6L7D56d07pKP6BEv HQjL6WqnW+8n47sxQD3t/9B86I7C/bj8ltEqJJh59OgeIOl8lfWJghloYF00juyBXGShIo xv1rzrddaGsDX/9eV1WxWVR4yLiaZjFmOkkeMDgWvGFaCwxlK/EBTZsNvj50Hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782984898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fC/RYjpVF9hCAKviZb2lPR/GhKvwSh5WsrHkaxcN1Yc=; b=q8+wX6jG848jJcOG7uLa0w3uaz+kMTFDq4sbiC418ImHEqauxoGKZREjd0dxf3brQ80KDF dQDYJlVhG4h2OW3g9Txh1lv4oicVbb/z3QMRaQ7KKn5F3huy0VT9oylMWZYM32fnID8ceK h8Tl6wMzaN6PDHeP+GQJ+PbE1CR8ji9vBnQ4+/3FES3UcPcNDvtd3rbgvjuP+NbBfee96l xDuN01rrtXjQN/2kixYm9W4VpzCmPCAlt+zEGp2R6pSPzoPxMlTKlint6CHmnGu/LaK8Ad QDnNrDyKiM9on94Sub2G1qgkEN0GhuWhHeCwa58rHbJv2K4uqXdxwNTnSr9p4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4grWv6309XzwDx for ; Thu, 02 Jul 2026 09:34:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cfec by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 02 Jul 2026 09:34:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: fbc039e512c3 - main - tests: fix checksum computation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fbc039e512c3bb1635ad20cc8f70ad608ea818b7 Auto-Submitted: auto-generated Date: Thu, 02 Jul 2026 09:34:53 +0000 Message-Id: <6a4630bd.3cfec.2ce5667c@gitrepo.freebsd.org> The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=fbc039e512c3bb1635ad20cc8f70ad608ea818b7 commit fbc039e512c3bb1635ad20cc8f70ad608ea818b7 Author: Michael Tuexen AuthorDate: 2026-07-01 16:07:04 +0000 Commit: Michael Tuexen CommitDate: 2026-07-01 16:07:04 +0000 tests: fix checksum computation This fixes an endianness bug in sys/netinet/ip_reass_test. Just use the code from RFC 1071. Reported by: glebius Reviewed by: glebius, Timo Völker MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D57988 --- tests/sys/netinet/ip_reass_test.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/tests/sys/netinet/ip_reass_test.c b/tests/sys/netinet/ip_reass_test.c index 538815bd7a2c..e32fb63f34da 100644 --- a/tests/sys/netinet/ip_reass_test.c +++ b/tests/sys/netinet/ip_reass_test.c @@ -55,24 +55,28 @@ struct lopacket { char payload[]; }; -static void -update_cksum(struct ip *ip) +static uint16_t +in_cksum(void *data, size_t len) { + uint16_t *cksump; size_t i; uint32_t cksum; - uint8_t *cksump; - uint16_t tmp; + ATF_REQUIRE(len % 2 == 0); + cksump = (uint16_t *)data; + cksum = 0; + for (i = 0; i < len / sizeof(uint16_t); i++) + cksum += *cksump++; + while ((cksum >> 16) != 0) + cksum = (cksum & 0xffff) + (cksum >> 16); + return ((uint16_t)~cksum); +} + +static void +update_cksum(struct ip *ip) +{ ip->ip_sum = 0; - cksump = (char *)ip; - for (cksum = 0, i = 0; i < sizeof(*ip) / sizeof(uint16_t); i++) { - tmp = *cksump++; - tmp = tmp << 8 | *cksump++; - cksum += ntohs(tmp); - } - cksum = (cksum >> 16) + (cksum & 0xffff); - cksum = ~(cksum + (cksum >> 16)); - ip->ip_sum = htons((uint16_t)cksum); + ip->ip_sum = in_cksum(ip, sizeof(struct ip)); } static struct lopacket *