From owner-svn-ports-head@freebsd.org  Fri Jun 22 22:51:41 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2B67100243D;
 Fri, 22 Jun 2018 22:51:40 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (unknown [IPv6:2607:f440::d144:242])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A7CF086811;
 Fri, 22 Jun 2018 22:51:40 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (localhost [127.0.0.1])
 by ainaz.pair.com (Postfix) with ESMTP id B049F125459;
 Fri, 22 Jun 2018 18:51:33 -0400 (EDT)
Received: from anthias.microfocus.com (charybdis-ext.suse.de [195.135.221.2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id F17B25C1BE;
 Fri, 22 Jun 2018 18:51:32 -0400 (EDT)
Date: Sat, 23 Jun 2018 00:51:31 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Lars Engels <lme@FreeBSD.org>, Michael Danilov <mike.d.ft402@gmail.com>
cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r472962 - head/net-mgmt/aircrack-ng
In-Reply-To: <201806210759.w5L7x2cJ042398@repo.freebsd.org>
Message-ID: <alpine.LSU.2.21.1806221205330.3747@anthias.pfeifer.com>
References: <201806210759.w5L7x2cJ042398@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 22:51:41 -0000

Hi Lars and Michael,

On Thu, 21 Jun 2018, Lars Engels wrote:
>   - Set required GCC version to 6+, so that the default gcc version is chosen.
>   GCC isn't needed to successfully building the port, but according to upstream
>
>   PR:		228747
>   Submitted by:	Michael Danilov <mike.d.ft402@gmail.com>

> -USE_GCC=	7+
> +USE_GCC=	6+

in that case, the canonical way to state that is

  USE_GCC=	yes

which has the advantage that it'll do what you are aiming for,
without a need to adjust as the default version moves (or if
some user changes the default via Mk/bsd.default-versions.mk).

I'll be happy to make this change if you agree.

Gerald