From owner-freebsd-hackers Wed Nov 15 01:28:09 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id BAA11150 for hackers-outgoing; Wed, 15 Nov 1995 01:28:09 -0800 Received: from tfs.com (tfs.com [140.145.250.1]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id BAA11136 for ; Wed, 15 Nov 1995 01:28:01 -0800 Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP id m0tFe8N-0003w1C; Wed, 15 Nov 95 01:27 PST Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id KAA02630; Wed, 15 Nov 1995 10:27:57 +0100 X-Authentication-Warning: localhost.tfs.com: Host localhost didn't use HELO protocol To: davidg@Root.COM cc: Bruce Evans , peter@haywire.dialix.com, freebsd-hackers@freebsd.org Subject: Re: Can't NFS mount with latest -current In-reply-to: Your message of "Wed, 15 Nov 1995 00:15:21 PST." <199511150815.AAA00161@corbin.Root.COM> Date: Wed, 15 Nov 1995 10:27:56 +0100 Message-ID: <2628.816427676@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-hackers@freebsd.org Precedence: bulk > >>>Anyway, Poul-Henning has created two sysctl types.. one is a > >>>null-terminated "C-style" string, and the other is an "opaque" chunk > >>>of byte counted memory. IMHO, the string version should always return > >>>the correct amount of characters that the string actually uses. If > >>>the whole block is to be returned, that's what the opaque type is for. > > > >> Yes, the "size" argument should be used to limit the copy, not prevent i t > >>from happening. We should be using copyoutstr() for this. > > > >We shouldn't be using copyoutstr() for this. > ... > >copyoutstr() is the most complicated routine in support.s, but is > >currently unused. > > Are you saying that you would like to officially remove support for > copyoutstr() in favor of strlen/copyout? I can agree with that. BTW, we > should remove the #if 0'd crap in cpufunc.h: I'd vote for killing copyoutstr too. -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.