Date: Thu, 29 Dec 2022 14:10:35 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Nuno Teixeira <eduardo@freebsd.org> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <Y62RyxK3cTqEipNN@KGPE-D16> In-Reply-To: <CAFDf7ULdkd_jS=0Nr9MgaKpD3hEVAwk%2BhQFiCvdAFyZZiSpORw@mail.gmail.com> References: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> <Y6ogXR2mFK%2BfqcH/@KGPE-D16> <CAFDf7U%2BT=4DQeoHeOY5UH_8hnYd1CujW=wgA25Nx9A6Wt5AN=A@mail.gmail.com> <Y6w6xrKKj42u1tem@KGPE-D16> <Y6xBgNjWEY5uMfBl@graf.pompo.net> <Y6xH0xp1pSr5NBiv@KGPE-D16> <CAFDf7U%2BiEXKkpFkyjtN-wRa6N%2BNT1X5%2BLLqzZhv%2By-vjPsRAGA@mail.gmail.com> <CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg@mail.gmail.com> <Y6zy1jzT1CBLSzDE@KGPE-D16> <CAFDf7ULdkd_jS=0Nr9MgaKpD3hEVAwk%2BhQFiCvdAFyZZiSpORw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--6r8wC0gHyxtDxRHn Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Nope. You can use the maintainer's version. If you append USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler parameters). I have tried that in the past and it doesn't work, only the first one will be used. On 22-12-29 09:31:44, Nuno Teixeira wrote: >maintainer is trying to "force" me to use: > >--- >.if !exists(/usr/include/omp.h) >USES+=3D gcc-c++11-lib >.else >USES+=3D compiler:c++14-lang >.endif >--- > >But I think we can avoid .else statement and use compiler:c++14-lang on >"normal" USES since compiler will be overrided by the .if condition. >Am I correct? > >Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quinta, 29/12/2022 =C3=A0= (s) >01:52: > >> Yes, that is ok. >> >> On 22-12-29 00:26:01, Nuno Teixeira wrote: >> >(...) >> > >> >Got confused with that commit that have some months old. >> > >> >Current Makefile has: >> >--- >> >.if !exists(/usr/include/omp.h) >> >USES+=3D compiler:c++14-lang >> >USE_GCC=3D yes >> >.else >> >USES+=3D compiler:c++14-lang >> >.endif >> >--- >> >And it should be corrected to: >> >--- >> >.if !exists(/usr/include/omp.h) >> >USES+=3D compiler:gcc-c++11-lib >> >.endif >> >--- >> > >> >Is that ok? >> >Sorry because I've got confused >> > >> >Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/2022 >> =C3=A0(s) >> >23:59: >> > >> >> You have fixed it in >> >> >> https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121= a2e745ed4293 >> >> >> >> I think I understand it better now >> >> >> >> Thanks >> >> >> >> Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 >> =C3=A0(s) >> >> 13:43: >> >> >> >>> It would and I was against removal of USES=3Dcompiler:openmp but it = was >> >>> done anyway without any regard for architectures that don't have >> libomp. >> >>> >> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: >> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj <pkubaj@= anongoth.pl> >> >>> =C3=A9crivait : >> >>> > >> >>> >> If OpenMP is still necessary, then the best way would be: >> >>> >> .if !exists(/usr/include/omp.h) >> >>> >> USES+=3D compiler:gcc-c++11-lib >> >>> >> .else >> >>> >> USES+=3D compiler:c++14-lang >> >>> >> .endif >> >>> > >> >>> >It would be great to re-add an argument "openmp" in Mk/Uses/ >> compiler.mk >> >>> >to put this kind of code at a central place. >> >>> >-- >> >>> >Th. Thomas. >> >>> >> >> >> >> >> >> -- >> >> Nuno Teixeira >> >> FreeBSD Committer (ports) >> >> >> > >> > >> >-- >> >Nuno Teixeira >> >FreeBSD Committer (ports) >> > > >--=20 >Nuno Teixeira >FreeBSD Committer (ports) --6r8wC0gHyxtDxRHn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOtkcswFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydLdwP/0CXuTnpYMVjG2Hvx7l3++LR8u5hGDv5JXLmpVXCvw0Sd+xAZiDl7+CZ /o0V88IsIQUXL0y6hf9HlSk75Kj6OC2+ust1yLcV+j2sCn98QEO8XoQJnwwa2ipg SNoyfOynRumrzfHv2F8PyqlO7zHY+GR1aIHI8nczdjanbsk6G/ylSP/fMloSLDK7 aV/MLnYyQRkjl1Ln/u7EB3caKubP3yIycpo5NCaKlEvSlOvS0z7asq+DCvdkv6Nd gZrS7hzL4/94sNnWx8NwAr1RC4NoKbUtraZURBIQxCSqehvUyQwdqx2bdWymD8Ea l01cseX+HUisXRs4kSTF0tNYd6831B23mCFY9wbg1qJ0r70dMQs8gxDtI79oIc0b AeyHZBBgcs2FMdwR4IKiFXaMakHjDa52Eobsj9Gx6eoYPMucNIteyHYHWxUcDUT7 QJi4ZTOup0SlrY+DgzFyMWeHVrZy0iGmpqBsslN4V5KE8TQDbsg5kV5ItK+nuEws OeGoxoiGS+8+6bdpwkofopqUdT5EbinABqFSzpmaj9Rv9mU5GOh7WwWwE+da9OjY 7i874y57MdSyAXV+muf+xUjshIxbrTozn1J6uTDrx9P99EP2nFuZVawJTc6B119v xQNVmq74/F84Y8aA2Vbd/D6pJB67j1wjnhdyAoUVypGB/67oto22 =Lw9f -----END PGP SIGNATURE----- --6r8wC0gHyxtDxRHn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y62RyxK3cTqEipNN>