Date: Thu, 29 Dec 2022 13:18:25 +0000 From: Nuno Teixeira <eduardo@freebsd.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: Gerald Pfeifer <gerald@pfeifer.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <CAFDf7U%2B%2Bd63E-fgCCZcf9oGrQ3853fN0yUPxdqFQOPJmD8-o7A@mail.gmail.com> In-Reply-To: <Y62RyxK3cTqEipNN@KGPE-D16> References: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> <Y6ogXR2mFK%2BfqcH/@KGPE-D16> <CAFDf7U%2BT=4DQeoHeOY5UH_8hnYd1CujW=wgA25Nx9A6Wt5AN=A@mail.gmail.com> <Y6w6xrKKj42u1tem@KGPE-D16> <Y6xBgNjWEY5uMfBl@graf.pompo.net> <Y6xH0xp1pSr5NBiv@KGPE-D16> <CAFDf7U%2BiEXKkpFkyjtN-wRa6N%2BNT1X5%2BLLqzZhv%2By-vjPsRAGA@mail.gmail.com> <CAFDf7UKi7W-B3BGidymynPGJNX6Sp%2BdgUZfHKsisb=ooUvPPZg@mail.gmail.com> <Y6zy1jzT1CBLSzDE@KGPE-D16> <CAFDf7ULdkd_jS=0Nr9MgaKpD3hEVAwk%2BhQFiCvdAFyZZiSpORw@mail.gmail.com> <Y62RyxK3cTqEipNN@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f2a5ea05f0f75297 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK, thanks a lot for explanation! Cheers Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quinta, 29/12/2022 =C3=A0(= s) 13:10: > Nope. > > You can use the maintainer's version. If you append > USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be > USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler > parameters). > > I have tried that in the past and it doesn't work, only the first one > will be used. > > On 22-12-29 09:31:44, Nuno Teixeira wrote: > >maintainer is trying to "force" me to use: > > > >--- > >.if !exists(/usr/include/omp.h) > >USES+=3D gcc-c++11-lib > >.else > >USES+=3D compiler:c++14-lang > >.endif > >--- > > > >But I think we can avoid .else statement and use compiler:c++14-lang on > >"normal" USES since compiler will be overrided by the .if condition. > >Am I correct? > > > >Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quinta, 29/12/2022 =C3= =A0(s) > >01:52: > > > >> Yes, that is ok. > >> > >> On 22-12-29 00:26:01, Nuno Teixeira wrote: > >> >(...) > >> > > >> >Got confused with that commit that have some months old. > >> > > >> >Current Makefile has: > >> >--- > >> >.if !exists(/usr/include/omp.h) > >> >USES+=3D compiler:c++14-lang > >> >USE_GCC=3D yes > >> >.else > >> >USES+=3D compiler:c++14-lang > >> >.endif > >> >--- > >> >And it should be corrected to: > >> >--- > >> >.if !exists(/usr/include/omp.h) > >> >USES+=3D compiler:gcc-c++11-lib > >> >.endif > >> >--- > >> > > >> >Is that ok? > >> >Sorry because I've got confused > >> > > >> >Nuno Teixeira <eduardo@freebsd.org> escreveu no dia quarta, 28/12/202= 2 > >> =C3=A0(s) > >> >23:59: > >> > > >> >> You have fixed it in > >> >> > >> > https://cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a= 2e745ed4293 > >> >> > >> >> I think I understand it better now > >> >> > >> >> Thanks > >> >> > >> >> Piotr Kubaj <pkubaj@anongoth.pl> escreveu no dia quarta, 28/12/2022 > >> =C3=A0(s) > >> >> 13:43: > >> >> > >> >>> It would and I was against removal of USES=3Dcompiler:openmp but i= t > was > >> >>> done anyway without any regard for architectures that don't have > >> libomp. > >> >>> > >> >>> On 22-12-28 14:15:44, Thierry Thomas wrote: > >> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Piotr Kubaj < > pkubaj@anongoth.pl> > >> >>> =C3=A9crivait : > >> >>> > > >> >>> >> If OpenMP is still necessary, then the best way would be: > >> >>> >> .if !exists(/usr/include/omp.h) > >> >>> >> USES+=3D compiler:gcc-c++11-lib > >> >>> >> .else > >> >>> >> USES+=3D compiler:c++14-lang > >> >>> >> .endif > >> >>> > > >> >>> >It would be great to re-add an argument "openmp" in Mk/Uses/ > >> compiler.mk > >> >>> >to put this kind of code at a central place. > >> >>> >-- > >> >>> >Th. Thomas. > >> >>> > >> >> > >> >> > >> >> -- > >> >> Nuno Teixeira > >> >> FreeBSD Committer (ports) > >> >> > >> > > >> > > >> >-- > >> >Nuno Teixeira > >> >FreeBSD Committer (ports) > >> > > > > > >-- > >Nuno Teixeira > >FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000f2a5ea05f0f75297 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>OK, thanks a lot for explanation!</div><div><br></div= ><div>Cheers<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr"= class=3D"gmail_attr">Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl"= >pkubaj@anongoth.pl</a>> escreveu no dia quinta, 29/12/2022 =C3=A0(s) 13= :10:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px= 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Nope.<br> <br> You can use the maintainer's version. If you append<br> USES=3Dcompiler:c++14-lang for everyone, then without omp.h there will be<b= r> USES=3Dcompiler:c++14-lang compiler:gcc-c++11-lib (two compiler<br> parameters).<br> <br> I have tried that in the past and it doesn't work, only the first one<b= r> will be used.<br> <br> On 22-12-29 09:31:44, Nuno Teixeira wrote:<br> >maintainer is trying to "force" me to use:<br> ><br> >---<br> >.if !exists(/usr/include/omp.h)<br> >USES+=3D gcc-c++11-lib<br> >.else<br> >USES+=3D compiler:c++14-lang<br> >.endif<br> >---<br> ><br> >But I think we can avoid .else statement and use compiler:c++14-lang on= <br> >"normal" USES since compiler will be overrided by the .if con= dition.<br> >Am I correct?<br> ><br> >Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl" target=3D"_blank"= >pkubaj@anongoth.pl</a>> escreveu no dia quinta, 29/12/2022 =C3=A0(s)<br= > >01:52:<br> ><br> >> Yes, that is ok.<br> >><br> >> On 22-12-29 00:26:01, Nuno Teixeira wrote:<br> >> >(...)<br> >> ><br> >> >Got confused with that commit that have some months old.<br> >> ><br> >> >Current Makefile has:<br> >> >---<br> >> >.if !exists(/usr/include/omp.h)<br> >> >USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang= <br> >> >USE_GCC=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 yes<br> >> >.else<br> >> >USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compiler:c++14-lang= <br> >> >.endif<br> >> >---<br> >> >And it should be corrected to:<br> >> >---<br> >> >.if !exists(/usr/include/omp.h)<br> >> >USES+=3D=C2=A0 compiler:gcc-c++11-lib<br> >> >.endif<br> >> >---<br> >> ><br> >> >Is that ok?<br> >> >Sorry because I've got confused<br> >> ><br> >> >Nuno Teixeira <<a href=3D"mailto:eduardo@freebsd.org" targe= t=3D"_blank">eduardo@freebsd.org</a>> escreveu no dia quarta, 28/12/2022= <br> >> =C3=A0(s)<br> >> >23:59:<br> >> ><br> >> >> You have fixed it in<br> >> >><br> >> <a href=3D"https://cgit.freebsd.org/ports/commit/?id=3Db02f812b438= 70dc615b6fc713121a2e745ed4293" rel=3D"noreferrer" target=3D"_blank">https:/= /cgit.freebsd.org/ports/commit/?id=3Db02f812b43870dc615b6fc713121a2e745ed42= 93</a><br> >> >><br> >> >> I think I understand it better now<br> >> >><br> >> >> Thanks<br> >> >><br> >> >> Piotr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl" tar= get=3D"_blank">pkubaj@anongoth.pl</a>> escreveu no dia quarta, 28/12/202= 2<br> >> =C3=A0(s)<br> >> >> 13:43:<br> >> >><br> >> >>> It would and I was against removal of USES=3Dcompiler= :openmp but it was<br> >> >>> done anyway without any regard for architectures that= don't have<br> >> libomp.<br> >> >>><br> >> >>> On 22-12-28 14:15:44, Thierry Thomas wrote:<br> >> >>> >Le mer. 28 d=C3=A9c. 22 =C3=A0 13:47:02 +0100, Pi= otr Kubaj <<a href=3D"mailto:pkubaj@anongoth.pl" target=3D"_blank">pkuba= j@anongoth.pl</a>><br> >> >>> =C3=A9crivait :<br> >> >>> ><br> >> >>> >> If OpenMP is still necessary, then the best = way would be:<br> >> >>> >> .if !exists(/usr/include/omp.h)<br> >> >>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:= gcc-c++11-lib<br> >> >>> >> .else<br> >> >>> >> USES+=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0compiler:= c++14-lang<br> >> >>> >> .endif<br> >> >>> ><br> >> >>> >It would be great to re-add an argument "ope= nmp" in Mk/Uses/<br> >> <a href=3D"http://compiler.mk" rel=3D"noreferrer" target=3D"_blank= ">compiler.mk</a><br> >> >>> >to put this kind of code at a central place.<br> >> >>> >--<br> >> >>> >Th. Thomas.<br> >> >>><br> >> >><br> >> >><br> >> >> --<br> >> >> Nuno Teixeira<br> >> >> FreeBSD Committer (ports)<br> >> >><br> >> ><br> >> ><br> >> >--<br> >> >Nuno Teixeira<br> >> >FreeBSD Committer (ports)<br> >><br> ><br> ><br> >-- <br> >Nuno Teixeira<br> >FreeBSD Committer (ports)<br> </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g= mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun= o Teixeira<br>FreeBSD Committer (ports)</span></div></div> --000000000000f2a5ea05f0f75297--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2B%2Bd63E-fgCCZcf9oGrQ3853fN0yUPxdqFQOPJmD8-o7A>