From nobody Mon Oct 16 17:53:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S8Ppm1D8Kz4xd06; Mon, 16 Oct 2023 17:53:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S8Ppm0n84z3cWY; Mon, 16 Oct 2023 17:53:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697478784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iglNtaecCwgF/yg12pECPzqUXqwPwIlxTmz4KvGxJzk=; b=pTL48YKWWLhqFtqycx7Hs0pNnkvGwwyg9Boc3souILqVFwc+CD4IcOaH/TzSFphmnhUQNd m9awD/ctvMvV1YvuQtAoPYJNIQTKcw4iKmuj+pEsdAKgr63mEi50AQpClB41dVNG2+tiUl q0qiGH1lDzTXdZgox1QhBK7jTBokOdNnWJE94X8hskGGKTPsG0gJROX4/jrdTJzj1ygqEP Gg5JFbxl34lQyl6yvIBJTCxEM5Uu3PlUPgROzPvEkbVzZrehod3Wrq8+3xrJqusS0dsABQ 8UpdbahM53GXHzuZxXUhdttP9SMvhaswQw20YqpJelS35SGGa9hJwkyRkin75w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697478784; a=rsa-sha256; cv=none; b=Fmlj/hPrtV082tJdILM/N0LSMDfYxdJKj+BhXq1ZWCv9jHXMwfwxRVoqCqeuypXjy1V4z4 IbDAxW6q7X8qVv9bBRtjL3QLaKnJl+vSTF5HOkf+SpTC6MrAyI+tKBXbkcXepUhnVJ1ixx jJCo6oUl+Cu0ux6bqqqZ4ewQV8N0Dl8iR/aQzCDaNlFCx7oTjioVc0xM5YANAyf78tUboe oJXhyE06wTrSPo0hAzRZATTS/dZA6R4l17tQEcgLMiUhfftgr4K75ZTyEtLAKIh1boSAzA yUpGAPSFEaKR0m/UR8Wm7A+5kRoV5H3gsPyCnJixgiEr+MOH/Efw5dmdzOcL7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697478784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iglNtaecCwgF/yg12pECPzqUXqwPwIlxTmz4KvGxJzk=; b=hg/+/3S5eZKtqyn0UtKpDuXBKkhN4rG45R0dHwEK/2Pxr4KuFLs2kFCwxeT+y91Y1asDMO lhp/yXf6JsXufgk75pMMlsBjXrGX9Wrtgump1BSQkwsIE5StCYLaeiPG0D/cs0bIEehQxu gnYvGlaQw7BtPtsfCdyk/yROrsFgPjyd9HU47toDR41Adg07gCVLmIgV1zX8edneylNa3z Igghu0ByjznToawG3h81z2YQtZWWBcZQKijrMf5LYNmI1HPYB9sj2Z2EsfWIDW1TEsp87X 1kV2bYqWOxUPiA9J7Pjtk6izP9HEcrW98aTFLFsQGM+lhrY0ZVx2Q9cFAN4EJg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S8Ppl6g2Lzq2n; Mon, 16 Oct 2023 17:53:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39GHr3T8027781; Mon, 16 Oct 2023 17:53:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39GHr3Qd027778; Mon, 16 Oct 2023 17:53:03 GMT (envelope-from git) Date: Mon, 16 Oct 2023 17:53:03 GMT Message-Id: <202310161753.39GHr3Qd027778@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: c90c45ac725b - stable/13 - ptsname.3: accommodate upcoming POSIX Issue 8 ptsname_r List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: c90c45ac725ba2a7f9bb940a1d555a025b7e47aa Auto-Submitted: auto-generated The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=c90c45ac725ba2a7f9bb940a1d555a025b7e47aa commit c90c45ac725ba2a7f9bb940a1d555a025b7e47aa Author: Ed Maste AuthorDate: 2023-10-13 20:25:53 +0000 Commit: Ed Maste CommitDate: 2023-10-16 17:52:57 +0000 ptsname.3: accommodate upcoming POSIX Issue 8 ptsname_r POSIX has accepted a proposal[1] to add glibc-compatible ptsname_r. It indicates an error by returning the error number, rather than returning -1 and setting errno. Update RETURN VALUES in ptsname_r's man page now to encourage folks to test that the return value != 0 rather than == -1. [1] https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 Reported by: Collin Funk Reviewed by: kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42204 (cherry picked from commit a5ed6a815e38d6c622cd97a6020592ded579cf7a) --- lib/libc/stdlib/ptsname.3 | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/lib/libc/stdlib/ptsname.3 b/lib/libc/stdlib/ptsname.3 index 532ce9e92ae0..df23e9ae6129 100644 --- a/lib/libc/stdlib/ptsname.3 +++ b/lib/libc/stdlib/ptsname.3 @@ -29,7 +29,7 @@ .\" NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS .\" SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. .\" -.Dd October 17, 2020 +.Dd October 14, 2023 .Dt PTSNAME 3 .Os .Sh NAME @@ -104,7 +104,7 @@ function clears the lock held on the pseudo-terminal pair for the master device specified with .Fa fildes . .Sh RETURN VALUES -.Rv -std grantpt ptsname_r unlockpt +.Rv -std grantpt unlockpt .Pp The .Fn ptsname @@ -112,6 +112,19 @@ function returns a pointer to the name of the slave device on success; otherwise a .Dv NULL pointer is returned. +.Pp +The +.Fn ptsname_r +function returns the value 0 if successful; +otherwise a nonzero value is returned and the global variable +.Va errno +is set to indicate the error. +Note: +.Fn ptsname_r +was previously documented as returning -1 on error. +In the future it will be changed to return an error number, for POSIX +compatibility. +Therefore, callers should not check for -1. .Sh ERRORS The .Fn grantpt ,