From owner-freebsd-bugs Mon May 6 11:50: 6 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id A23E537B400 for ; Mon, 6 May 2002 11:50:02 -0700 (PDT) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g46Io2N02248; Mon, 6 May 2002 11:50:02 -0700 (PDT) (envelope-from gnats) Date: Mon, 6 May 2002 11:50:02 -0700 (PDT) Message-Id: <200205061850.g46Io2N02248@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: David Malone Subject: Re: kern/37786: spppcontrol fails if kernel is not compiled with INET6 Reply-To: David Malone Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/37786; it has been noted by GNATS. From: David Malone To: Ari Suutari Cc: freebsd-gnats-submit@FreeBSD.org, joerg@FreeBSD.org Subject: Re: kern/37786: spppcontrol fails if kernel is not compiled with INET6 Date: Mon, 6 May 2002 19:40:05 +0100 On Mon, May 06, 2002 at 04:17:36AM -0700, Ari Suutari wrote: > Using spppcontrol to change authentication parameters with ISDN fails > always with "spppcontrol: SIOCSIFGENERIC(SPPPIOSDEFS): Invalid argument". > This is caused by break statement in if_spppsubr.c being inside > #ifdef INET6 (see line 5174). It looks reasonably obvious to me that this patch is correct, but Joerg added it, so maybe he can confirm that for me. David. Index: if_spppsubr.c =================================================================== RCS file: /cvs/FreeBSD-CVS/src/sys/net/if_spppsubr.c,v retrieving revision 1.93 diff -u -r1.93 if_spppsubr.c --- if_spppsubr.c 1 May 2002 04:18:36 -0000 1.93 +++ if_spppsubr.c 6 May 2002 18:34:16 -0000 @@ -5145,8 +5145,8 @@ sp->confflags |= CONF_ENABLE_IPV6; else sp->confflags &= ~CONF_ENABLE_IPV6; - break; #endif + break; default: rv = EINVAL; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message