From owner-svn-ports-all@freebsd.org  Fri Apr 27 02:36:48 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E0F4FBE9B1;
 Fri, 27 Apr 2018 02:36:48 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BCF9070A35;
 Fri, 27 Apr 2018 02:36:46 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 7e59ab54
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Thu, 26 Apr 2018 20:36:44 -0600 (MDT)
Content-Type: text/plain;
	charset=utf-8;
	delsp=yes;
	format=flowed
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
Subject: Re: svn commit: r468319 - in head/mail: opensmtpd opensmtpd-devel
 opensmtpd-devel/files opensmtpd/files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <2315c626-9bc9-35bd-0f61-3f8e77f54237@FreeBSD.org>
Date: Thu, 26 Apr 2018 20:36:42 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: 8bit
Message-Id: <9D94AB40-9623-45BA-8F5C-95B548DF0D40@adamw.org>
References: <201804260053.w3Q0r1ls098687@repo.freebsd.org>
 <03CA4FC0-D636-4A40-A820-AF746EF35499@adamw.org>
 <2315c626-9bc9-35bd-0f61-3f8e77f54237@FreeBSD.org>
To: fluffy@FreeBSD.org
X-Mailer: Apple Mail (2.3445.6.18)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2018 02:36:48 -0000

> On 26 Apr, 2018, at 20:30, Dima Panov <fuffy@FreeBSD.org> wrote:
>
>
>
> Adam Weinberger wrote:
>>> On 25 Apr, 2018, at 18:53, Dima Panov <fluffy@FreeBSD.org> wrote:
>>>
>>> Author: fluffy
>>> Date: Thu Apr 26 00:53:01 2018
>>> New Revision: 468319
>>> URL: https://svnweb.freebsd.org/changeset/ports/468319
>>>
>>> Log:
>>>   - Pet MDA part, add brackets around Return-Path as per RFC5322 §3.6.6.
>>>
>>>   Missing brackets lead to a panic when a malformed address line
>>>   is fed to dovecot-lda
>>>
>>>   Submitted by:    gahr
>>>   Reported by:    brnrd via dovecot ML
>>>   Obtained from:    https://github.com/OpenSMTPD/OpenSMTPD/pull/847/commits/725ba4fa2ddf23bbcd1ff9ec92e86bbfaa6825c8
>> Thanks for doing this, Dima. This should probably be merged to  
>> quarterly, no?
>
> Only Dovecot23+ affected this "bug" yet, so while 2018Q2 lives without  
> it, MFH is not critically needed.
> But yes, I'm also thinking about MFH, just to be sured in.

IIRC rspamd had to work around this behavior a while back. It’s certainly a  
bug fix, but only dovecot seems to have broken spectacularly here recently.

I don’t feel strongly about it one way or the other. I defer to your  
judgement.

# Adam


—
Adam Weinberger
adamw@adamw.org
http://www.adamw.org