From owner-cvs-ports@FreeBSD.ORG Mon Dec 5 10:42:07 2005 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D4C216A420; Mon, 5 Dec 2005 10:42:07 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4FF3F43D5E; Mon, 5 Dec 2005 10:42:06 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id E25381173D; Mon, 5 Dec 2005 11:42:04 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 71805-02; Mon, 5 Dec 2005 11:41:58 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 9D5C211444; Mon, 5 Dec 2005 11:41:57 +0100 (CET) From: Florent Thoumie To: obrien@FreeBSD.org In-Reply-To: <20051205093626.GA68544@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> <20051205093626.GA68544@dragon.NUXI.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+TZZBsBHb7byy3Z4QMgb" Date: Mon, 05 Dec 2005 11:41:07 +0000 Message-Id: <1133782867.879.3.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev , ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: ports/shells/bash Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2005 10:42:07 -0000 --=-+TZZBsBHb7byy3Z4QMgb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le Lundi 05 d=C3=A9cembre 2005 =C3=A0 01:36 -0800, David O'Brien a =C3=A9cr= it : > On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > > Le Mercredi 30 novembre 2005 =C3=A0 13:37 -0500, Kris Kennaway a =C3=A9= crit : > > > On Wed, Nov 30, 2005 at 05:18:46PM +0000, Florent Thoumie wrote: > > > > Le Mercredi 30 novembre 2005 ?? 16:16 +0000, Alexey Dokuchaev a ??c= rit : > > > > > On Wed, Nov 30, 2005 at 03:10:12PM +0000, Florent Thoumie wrote: > > > > > > flz 2005-11-30 15:10:12 UTC > > > > > >=20 > > > > > > FreeBSD ports repository > > > > > >=20 > > > > > > Modified files: > > > > > > shells/bash Makefile=20 > > > > > > Log: > > > > > > - Add WANT_STATIC_BASH knob. > > > > >=20 > > > > > WANT_ prefix belongs to bpm's internal namespace; it should not b= e used > > > > > this way. > > > >=20 > > > > Agreed, Pav made the same notice but : > > > >=20 > > > > 1) that's not my port and, > > >=20 > > > Don't commit bogus changes, and > > >=20 > > > > 2) shells/bash2 has the same exact construction. > > >=20 > > > fix bogus changes when you encounter them. > >=20 > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > > in two weeks with maintainer timeout. >=20 > *sigh* why all the overhead? Since you're already in the middle of this > issue, please make it right for our users and just commit the fixed > version now. I'm fine with people fixing my mistakes, but that's not=20 something I would assume for every maintainer, so I just wanted=20 to ask in the first place. Anyway, thanks for answering, I'll commit it in a couple of=20 minutes. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD committer --=-+TZZBsBHb7byy3Z4QMgb Content-Type: application/pgp-signature; name=signature.asc Content-Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDlCdTMxEkbVFH3PQRAgHHAJ0W8YmgO9nIldNUlSivDsKlO9Wd4gCaAh9x RFYA1HYwrUuFg36mSjuRSLA= =p5yN -----END PGP SIGNATURE----- --=-+TZZBsBHb7byy3Z4QMgb--