From owner-svn-ports-all@FreeBSD.ORG Fri Mar 27 13:11:33 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0006C73A for ; Fri, 27 Mar 2015 13:11:32 +0000 (UTC) Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BCB34FE6 for ; Fri, 27 Mar 2015 13:11:32 +0000 (UTC) Received: by obvd1 with SMTP id d1so6633844obv.0 for ; Fri, 27 Mar 2015 06:11:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=gV4JltKTY254pg+92IcxYa6qj0Ct0y0Wuhg1JeHc1jU=; b=m3Kvc9UKY2l676zUiUo7943Y6/4uYdPHjy6ZjxJv65qmXZ43IE91EfnlPnJPFv2izI edhc5ch+rBAngTt+2KyGVIknmTK/33hu/PUZQf51Y7LbrJvDgLa6/HzClV4jOlo1nGK/ Shbe/jFTrDFMmApm7489ywra/0BCN6+HlUDCfH+mEiiObm3M9gW8srOtocMHITLwvA8G YwiY+8K0DiHHy/pEdQib3p26vJEXxV2DRyb7kSOnVE/p4sJTxL4c/qYiF+37dmRtGmTa zXHKdrf+xCkjt7uUoqY+VruNi2zmm56d+RVs5fAXOg0P8SLA29/jQ819Jof25mxotfTJ 9Ecg== X-Gm-Message-State: ALoCoQk6i6mzhO8eV2yQ+eheDSdhqaBLXq3RCP2gNsCbj5bMMUCFOlE/Fap63M7OdamuD8Z+bjRr X-Received: by 10.182.55.68 with SMTP id q4mr3633035obp.33.1427461885849; Fri, 27 Mar 2015 06:11:25 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.202.61.139 with HTTP; Fri, 27 Mar 2015 06:11:05 -0700 (PDT) In-Reply-To: <55106F0E.9090700@FreeBSD.org> References: <201503222311.t2MNBE8d075929@svn.freebsd.org> <551061EC.5090702@FreeBSD.org> <55106F0E.9090700@FreeBSD.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 27 Mar 2015 21:11:05 +0800 X-Google-Sender-Auth: ZxkuVrPWYFLiPXbIh6dA8QSXO2U Message-ID: Subject: Re: svn commit: r381968 - head/lang/gcc5 To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Gerald Pfeifer , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 13:11:33 -0000 On Tue, Mar 24, 2015 at 3:52 AM, Bryan Drewery wrote: > On 3/23/2015 2:44 PM, Gerald Pfeifer wrote: > > On Mon, 23 Mar 2015, Bryan Drewery wrote: > >>> USE_LDCONFIG stores the directory name to > >>> ${LOCALBASE}/libdata/ldconfig/${UNIQUENAME}. > >>> Since lang/gcc* now share same PORTNAME (gcc), you need to > >>> set UNIQUENAME manually. > >> I just hit this. I've fixed it in r382022. > > > > Thanks for fixing this, Bryan, but... > > > > ...doesn't this point to a design problem with the infrastructure? > > Definitely. I think UNIQUENAME is now really only used for USE_LDCONFIG. > It may make sense to default it to the values I put into the gcc ports. > > UNIQUENAME is also used by bsd.options.mk for UNIQUENAME_{SET,UNSET} support and OPTIONSFILE. I would vote for appending PKGNAMESUFFIX to UNIQUENAME. Regards, sunpoet > > > Mk/bsd.ports.mk says: > > > > # UNIQUENAME - A name for your port that is globally unique. By > default, > > # this is set to ${LATEST_LINK} when LATEST_LINK is set, > > # and to ${PKGNAMEPREFIX}${PORTNAME} otherwise. > > > > # PKGNAMESUFFIX - Suffix to specify compilation options or a version > > # designator (in case there are different versions of > > # one port as is the case for Tcl). > > > > If PKGNAMESUFFIX is used as Mat suggested (to carry a version number), > > shouldn't it become part of UNIQUENAME? Can this be improved? > > > > If not, I guess I should just revert PORTNAME to gcc47, gcc48, and > > so forth. Using PKGNAMESUFFIX is not providing the expected benefit. > > And things just are becoming more complex. :-( > > > > Gerald > > > > > -- > Regards, > Bryan Drewery > >