Date: Mon, 23 May 2011 21:59:23 +0400 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Warner Losh <imp@bsdimp.com> Cc: freebsd-geom@freebsd.org, Warner Losh <imp@freebsd.org>, Poul-Henning Kamp <phk@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: [RFC] Remove requirement of alignment to track from MBR scheme Message-ID: <4DDAA07B.9030004@yandex.ru> In-Reply-To: <9ED563AB-7B35-40F4-A33E-015317858401@bsdimp.com> References: <4DDA2F0B.2040203@yandex.ru> <D75B2856-D9D8-4BA3-BC54-8258610CEA06@xcllnt.net> <9ED563AB-7B35-40F4-A33E-015317858401@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 23.05.2011 21:38, Warner Losh wrote: > I'm all for carefully moving forward. There were parts of the patch > that seemed to be over-reaching. > > Personally, I'd just do something like the following since it > reflects what others do and implements the de-facto meaning of the > MBR: > > Index: sys/geom/part/g_part_mbr.c > =================================================================== > --- sys/geom/part/g_part_mbr.c (revision 222183) +++ > sys/geom/part/g_part_mbr.c (working copy) @@ -473,7 +473,7 @@ > > basetable->gpt_entries = NDOSPART; basetable->gpt_first = > basetable->gpt_sectors; - basetable->gpt_last = msize - (msize % > basetable->gpt_sectors) - 1; + basetable->gpt_last = msize - 1; There was report with different problem, the user created a partition that is aligned to 4KB sector size and it starts from the inside of first track, i.e. start offset < 63. And as he said, he did use sysinstall(8) for partitioning. -- WBR, Andrey V. Elsukov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJN2qB/AAoJEAHF6gQQyKF6HogH/3PaIT3CV6RofFope6Zjll+P XeAmLIkYvIVklPrXu34PCr+efhQ1gF0RjEttp1IvuF1KZPiGg06aU46On9vkUX7q Mn9DpO1eZSV0SwGdD332hRsN97OeU4zhh+QVwzPJLJ8ohA79BBFPmhAsqLig0hkm 1eQZNexsb4n5+BbWB681aZ/RCT9X8StoUeuOxsdFtnOvlEeZOGSRXESHc4Sgbl1x X8GfmDxSswQJHpumzwZZFaoJ2w4802pQzdxBBwjoR7M1I4JB/iAyAl2uRaS0hEDs 1CtluiLtItHps1z+PMqtua/he61k4eoqgtgVygoGKkRd3pPPoqiwD1+I1vPMfdo= =D8nU -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DDAA07B.9030004>