Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Mar 2019 00:10:31 +0000 (UTC)
From:      Kirk McKusick <mckusick@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r345044 - head/sys/ufs/ffs
Message-ID:  <201903120010.x2C0AVwW018867@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mckusick
Date: Tue Mar 12 00:10:31 2019
New Revision: 345044
URL: https://svnweb.freebsd.org/changeset/base/345044

Log:
  Add KASSERT to the softdep_disk_write_complete() function in the
  soft dependency code to ensure that it will be able to avoid a
  dangling dependency.
  
  Sponsored by: Netflix

Modified:
  head/sys/ufs/ffs/ffs_softdep.c

Modified: head/sys/ufs/ffs/ffs_softdep.c
==============================================================================
--- head/sys/ufs/ffs/ffs_softdep.c	Mon Mar 11 23:53:56 2019	(r345043)
+++ head/sys/ufs/ffs/ffs_softdep.c	Tue Mar 12 00:10:31 2019	(r345044)
@@ -11036,6 +11036,9 @@ softdep_disk_write_complete(bp)
 	struct buf *sbp;
 
 	ump = softdep_bp_to_mp(bp);
+	KASSERT(LIST_EMPTY(&bp->b_dep) || ump != NULL,
+	    ("softdep_disk_write_complete: softdep_bp_to_mp returned NULL "
+	     "with outstanding dependencies for buffer %p", bp));
 	if (ump == NULL)
 		return;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201903120010.x2C0AVwW018867>