From nobody Thu Jul 2 11:17:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4grZ9R5gwkz6kY3L for ; Thu, 02 Jul 2026 11:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4grZ9R3hLtz3XPh for ; Thu, 02 Jul 2026 11:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782991051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aorj7hIbfxHoYz8EiDxD3iHReizJGJzHLqc8qq2lO9s=; b=COpiZsG6kzyrns0mgbsgQaqZwR30rkcLHExS5qceFvWKpRZbKzLFFTNrIBJ3Cr0QJ/iTAq IOhLlq/0nFD5HPdPIZAH7Vtt84nXS560EYtU+pK8wKua+RGz4Oc+nHthMXBNWOGt2kK+G2 U2qBxttAIvtRGJnlTeU2xX9fxM5j9Q3ENk25+1mpdpaaoxELVBqx3xYsWdBFxq7UprHZ2m TouNRwzvSRC9la0c/cMG+8effxnbj1O6JYEUFm4VG3+4cC1UjX18vs5qsBfh68EFINU9AX +Kl+4FlazxKupWJEZDd5/J0OVoEqAgUnJ0jl6q+UAM/+8u0pFG0+FpV7Wb0Vuw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782991051; a=rsa-sha256; cv=none; b=tJ++RBP2pxRfRFads4iS5JRxQYS/7axV3ukyefgzbRjn3tKMctzrzsklMgE5hoQqo6drGY 4S6I/QqknzC9gPpIaxhBP3ZAIDBngpbn+MD0xu7dVOJU848C1sw+3wjJRlaOiaobN4rjTn 7COJP8Yky4sORoliBw1ogOaaNQ8GutRfmxbAiDA92ySs3r4w1TntkUCE8YTERopQDQmfuP p57G7DGFnCiHLVAW0thcJdYyJFbzaANwdlNxZ51qIBKUNSHQg1D4fa1y2tnbVEWKOubCGO lU9ROsgaopyx8NewR/BynK4eXf3JrU6N13reBEq4L9nbGvmYN/VmSvWeNs1cqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782991051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aorj7hIbfxHoYz8EiDxD3iHReizJGJzHLqc8qq2lO9s=; b=ukzoHx5AOKMDlG5SP+QHX34vu/jPU1odwjBCP9EaxWtNCYfSWrXbnjTMgrbWwyc3DROMPN 74y+I/6llWlmxOO0sXICxVPGRQy4rTuzpufUBSP3TTnQPqr5erfvIbAx7N+Cpe8sEsm3vk pdUk936ZZahowJWnwLp8VLBOJzNFWLAHWfTGyJX/PAXr3XM94VKfXpJ3xeUkNLm3ckek/C AJTdMrrWjkB2vxRYCGWKqYIkoo5XEnDsVoINLGpQ8F2dHbYn7DYGulrFHKsDFRyr3J0hnJ HHk+7SmI28VIdhohLIarKTXWRkRkyxy2DtbzavTqrV0gPRNlu+ShzTZUBAIv4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4grZ9R2RCDzyPY for ; Thu, 02 Jul 2026 11:17:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 22b35 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 02 Jul 2026 11:17:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: YAO, Xin From: Pouria Mousavizadeh Tehrani Subject: git: 8ad097de0226 - main - linuxulator: Fix operator precedence for LINUX_XATTR_FLAGS in setxattr() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8ad097de02263d92df3368a2f5035faa365e7956 Auto-Submitted: auto-generated Date: Thu, 02 Jul 2026 11:17:26 +0000 Message-Id: <6a4648c6.22b35.739f73f3@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=8ad097de02263d92df3368a2f5035faa365e7956 commit 8ad097de02263d92df3368a2f5035faa365e7956 Author: YAO, Xin AuthorDate: 2026-07-01 20:10:13 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-07-02 11:17:01 +0000 linuxulator: Fix operator precedence for LINUX_XATTR_FLAGS in setxattr() The LINUX_XATTR_FLAGS macro expands to (LINUX_XATTR_CREATE|LINUX_XATTR_REPLACE). Without parentheses around the macro expansion, the bitwise & operator has higher precedence than |, causing incorrect flag evaluation and a compiler warning. Add the missing parentheses around LINUX_XATTR_FLAGS to ensure correct operator grouping, matching the existing usage in getxattr(). Signed-off-by: YAO, Xin Fixes: 2c905456312b ("linuxulator: Fix O_PATH file descriptors errno for f*xattr(2)") Reviewed by: kib Pull Request: https://github.com/freebsd/freebsd-src/pull/2306 --- sys/compat/linux/linux_xattr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/compat/linux/linux_xattr.c b/sys/compat/linux/linux_xattr.c index 296b70ff409a..9a206089ada1 100644 --- a/sys/compat/linux/linux_xattr.c +++ b/sys/compat/linux/linux_xattr.c @@ -53,7 +53,7 @@ #define LINUX_XATTR_CREATE 0x1 #define LINUX_XATTR_REPLACE 0x2 -#define LINUX_XATTR_FLAGS LINUX_XATTR_CREATE|LINUX_XATTR_REPLACE +#define LINUX_XATTR_FLAGS (LINUX_XATTR_CREATE | LINUX_XATTR_REPLACE) struct listxattr_args { int fd; @@ -511,8 +511,8 @@ setxattr(struct thread *td, struct setxattr_args *args) return (error); } - if ((args->flags & ~(LINUX_XATTR_FLAGS)) != 0 || - args->flags == (LINUX_XATTR_FLAGS)) { + if ((args->flags & ~LINUX_XATTR_FLAGS) != 0 || + args->flags == LINUX_XATTR_FLAGS) { error = EINVAL; goto out_err; } @@ -520,7 +520,7 @@ setxattr(struct thread *td, struct setxattr_args *args) if (error != 0) goto out_err; - if ((args->flags & (LINUX_XATTR_FLAGS)) != 0 ) { + if ((args->flags & LINUX_XATTR_FLAGS) != 0) { if (args->path != NULL) error = kern_extattr_get_path(td, args->path, attrnamespace, attrname, NULL, args->size,