Date: Mon, 24 Feb 2003 01:37:08 -0800 From: Alfred Perlstein <bright@mu.org> To: phk@phk.freebsd.dk Cc: Scott Long <scottl@FreeBSD.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20030224093708.GM27224@elvis.mu.org> In-Reply-To: <30346.1046075295@critter.freebsd.dk> References: <20030224082427.GL27224@elvis.mu.org> <30346.1046075295@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
* phk@phk.freebsd.dk <phk@phk.freebsd.dk> [030224 00:28] wrote: > In message <20030224082427.GL27224@elvis.mu.org>, Alfred Perlstein writes: > > >> It børks a diskless machine, I posted the details to current@ some days ago. > > > >No, I realized relatively quickly what had gone wrong once someone > >posted a backtrace, I think it was scott. > > > >I also explained to scott why the ordering is needed. Right now he > >has rebroken the mp safety of filedescs so instead of a problem that's > >quite easy to find we have broken code that's racey and can lead to > >crashes. > > Well, if given the choice between something which works most of the time > on all the machines, and something which breaks some of the machines > totally all of the time, I prefer the former until the true fix can > be found. I didn't offer nor care about the choice you're describing, except to note that the comment describing it sucks as much as the change itself. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030224093708.GM27224>