From nobody Sun Nov 20 17:37:00 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NFd4X5K9lz4hjkh for ; Sun, 20 Nov 2022 17:37:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NFd4X2jrrz4LrL for ; Sun, 20 Nov 2022 17:37:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1668965820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yHElkx7mDdrPkx6PvHrJGXpfUmUfo96m5B0dHpL/NOk=; b=aD5I3qqg/OUb0tggKYx9Yd+kd+V5wzdOHIQy5/qamykUR6QVXLhBKLpYXKN5RQ1fRsBeFN GECx75DC1jtfLtZxfMEUL3V+RjWCxylCdk/02AcEfGe5Neijgew3WRVcHMW3tavXfAZW7p HiSmAg61l/hVz/nqtsZdvDkf+F23R4ir7mquAd8qSo6vD1g5HoWMk2c+R+9G5VECRXuXi9 2lw8KKRuv6Orv4OU+KMnqlzAGzZJmDf4EP6aB28a/hIkTFyj1YFckAfDdwFrGuzyqCenxg Qud0sxbnNY9LkyMHHu4yB1fsbfuv/uKlg61FWZAnv1CudRxjXG8r1zaLhgEbwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1668965820; a=rsa-sha256; cv=none; b=RhMZq3QOE66/qFOSfYJQUUuQQPUW367hPQ6prKaVvtEWW4tn0jxAiLJQVH8yoHuquZxHga 3Ra6Jh4lB40fgoAqvvgWB4J3T/T/pwM+pTYpKK2jZ5QftPPbeOoReQ5sUVMCQNTc50TaxP JmfagVVdIUq5XUCyX67N4WNY7Gy16NDzF7kPegK0LpQpWdqXJFdNxmExrH2GEZeQ+U/z82 bpC1ETlhfJhVLLxHK9zsuNyBJDG5aYQVF6zguB8Yk6rjkUnbot4wo/UOHpcVq4UXJXB3VU A29MPQVA33EtiE4oPJEKAtie8s+dcqdmwyvr/F4NUhlwRan89xY6zOe5I0Onjg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NFd4X1Vx2zXsd for ; Sun, 20 Nov 2022 17:37:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2AKHb0jS067212 for ; Sun, 20 Nov 2022 17:37:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2AKHb0BC067211 for bugs@FreeBSD.org; Sun, 20 Nov 2022 17:37:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 102502] [netgraph] [patch] ifconfig name does't rename netgraph node in network.subr Date: Sun, 20 Nov 2022 17:37:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: afedorov@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D102502 Aleksandr Fedorov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |afedorov@FreeBSD.org --- Comment #7 from Aleksandr Fedorov --- I think thi bug should be closed. root@xenon:/home/XeNoN # ifconfig tap create tap0 root@xenon:/home/XeNoN # ngctl ls There are 5 total nodes: Name: ngeth0 Type: eiface ID: 00000002 Num hooks: 1 Name: ngeth1 Type: eiface ID: 00000004 Num hooks: 1 Name: re0 Type: ether ID: 00000006 Num hooks: 0 Name: tap0 Type: ether ID: 0000000a Num hooks: 0 Name: ngctl44711 Type: socket ID: 0000000b Num hooks: 0 root@xenon:/home/XeNoN # ifconfig tap0 name renamed0 renamed0 root@xenon:/home/XeNoN # ngctl ls There are 5 total nodes: Name: ngeth0 Type: eiface ID: 00000002 Num hooks: 1 Name: ngeth1 Type: eiface ID: 00000004 Num hooks: 1 Name: re0 Type: ether ID: 00000006 Num hooks: 0 Name: renamed0 Type: ether ID: 0000000a Num hooks: 0 Name: ngctl44841 Type: socket ID: 0000000c Num hooks: 0 root@xenon:/home/XeNoN #=20 ng_ether: * * Interface arrival notification handler. * The notification is produced in two cases: * o a new interface arrives * o an existing interface got renamed * Currently the first case is handled by ng_ether_attach via special * hook ng_ether_attach_p. */ static void ng_ether_ifnet_arrival_event(void *arg __unused, struct ifnet *ifp) { char name[IFNAMSIZ]; node_p node; /* Only ethernet interfaces are of interest. */ if (ifp->if_type !=3D IFT_ETHER && ifp->if_type !=3D IFT_L2VLAN && ifp->if_type !=3D IFT_BRIDGE) return; /* * Just return if it's a new interface without an ng_ether companio= n. */ node =3D IFP2NG(ifp); if (node =3D=3D NULL) return; /* Try to give the node the same name as the new interface name */ ng_ether_sanitize_ifname(ifp->if_xname, name); if (ng_name_node(node, name) !=3D 0) log(LOG_WARNING, "%s: can't re-name node %s\n", __func__, name); } --=20 You are receiving this mail because: You are the assignee for the bug.=