From owner-svn-ports-head@freebsd.org Sun Mar 22 22:40:35 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E010126FB6F; Sun, 22 Mar 2020 22:40:35 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48lsst6cHwz4Mtj; Sun, 22 Mar 2020 22:40:34 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id D2A4033E42; Sun, 22 Mar 2020 18:40:33 -0400 (EDT) Received: from anthias (unknown [77.118.148.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id A577333E30; Sun, 22 Mar 2020 18:40:32 -0400 (EDT) Date: Sun, 22 Mar 2020 23:40:23 +0100 (CET) From: Gerald Pfeifer To: Kyle Evans , Baptiste Daroussin , Kubilay Kocak , vbox@FreeBSD.org cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528258 - in head/emulators/virtualbox-ose: . files In-Reply-To: <202003120041.02C0fXkP049507@repo.freebsd.org> Message-ID: References: <202003120041.02C0fXkP049507@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 48lsst6cHwz4Mtj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-4.47 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:hamza.pair.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_LONG(-0.99)[-0.994,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.18)[ip: (-7.28), ipnet: 209.68.0.0/18(-2.31), asn: 7859(-1.27), country: US(-0.05)]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 22:40:36 -0000 On Thu, 12 Mar 2020, Kyle Evans wrote: > Log: > emulators/virtualbox-ose: use contemporary GCC instead of old llvm This patch does not exactly do that. =:o > +# machine/atomic.h may use features that are only available in GCC9. This is > +# a workaround, anyways- we should be expressing USES= compiler:c++14-lang, but > +# contemporary clang miscompiles virtualbox in some fashion and yields runtime > +# breakage. > +USE_GCC= any USE_GCC=any allows using the age old, rotten, GCC 4.2 based system compiler where still present. This is practically not the case with ONLY_FOR_ARCHS= i386 amd64 which this port also specifies, but that is a subtle and indirect approach. (Where there is no /usr/bin/gcc USE_GCC=any degenerates to USE_GCC=yes, so the two are practically equivalent here, but still the USE_GCC=yes form is the one requiring a current version.) Okay to change this to USE_GCC=yes? Gerald PS: How do patches to this port actually get approved? The log has hardly any Approved by-s.