From owner-svn-src-all@freebsd.org Thu Sep 3 04:11:30 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 286203D8852; Thu, 3 Sep 2020 04:11:30 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BhnS20J3Bz3XQh; Thu, 3 Sep 2020 04:11:30 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 60E482A8A2; Thu, 3 Sep 2020 04:11:29 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.40.20081000 Date: Wed, 02 Sep 2020 21:11:23 -0700 Subject: Re: svn commit: r365264 - head/sys/dev/drm2 From: Ravi Pokala To: Niclas Zeising , , , Message-ID: <21223AE2-4D91-4DE4-90A5-CA991059FE2B@panasas.com> Thread-Topic: svn commit: r365264 - head/sys/dev/drm2 References: <202009021804.082I4nJ0098926@repo.freebsd.org> In-Reply-To: <202009021804.082I4nJ0098926@repo.freebsd.org> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Sep 2020 04:11:30 -0000 This appears to have broken tinderbox: [${SRCTOP}] rpokala% less _.arm.TEGRA124 ... ${SRCTOP}/sys/dev/drm2/drm_os_freebsd.c:129:3: error: implicit declarat= ion of function 'DRM_OBSOLETE' is invalid in C99 [-Werror,-Wimplicit-functio= n-declaration] DRM_OBSOLETE(kdev); ^ 1 error generated. --- drm_os_freebsd.o --- -Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Niclas Zeising Date: 2020-09-02, Wednesday at 11:04 To: , , Subject: svn commit: r365264 - head/sys/dev/drm2 Author: zeising (doc,ports committer) Date: Wed Sep 2 18:04:49 2020 New Revision: 365264 URL: https://svnweb.freebsd.org/changeset/base/365264 Log: drm2: Further improve deprecation message Further improve the drm2 deprecation message, only displaying informa= tion about the port for relevant architectures, and skipping the message completely from arm, which uses some parts of drm2 still. This is mostly intended to be merged to 12, since the base bits of dr= m2 on FreeBSD 13 are only really used on arm. Reviewed by: manu, mmel Approved by: manu MFC after: 3 days X-MFC-with: r364737 Differential Revision: https://reviews.freebsd.org/D26275 Modified: head/sys/dev/drm2/drm_os_freebsd.h Modified: head/sys/dev/drm2/drm_os_freebsd.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D --- head/sys/dev/drm2/drm_os_freebsd.h Wed Sep 2 17:46:56 2020 (r36526= 3) +++ head/sys/dev/drm2/drm_os_freebsd.h Wed Sep 2 18:04:49 2020 (r36526= 4) @@ -154,15 +154,21 @@ typedef void irqreturn_t; *(volatile u_int64_t *)(((vm_offset_t)(map)->handle) + \ (vm_offset_t)(offset)) =3D htole64(val) -#define DRM_PORT "graphics/drm-kmod" +#if !defined(__arm__) +#if defined(__i386__) || defined(__amd64__) || defined(__powerpc__) ||= defined(__aarch64__) +#define DRM_MSG "This code is deprecated. Install the graphics/drm-km= od pkg\n" +#else +#define DRM_MSG "This code is deprecated." +#endif #define DRM_OBSOLETE(dev) \ do { \ device_printf(dev, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D\n"); \ - device_printf(dev, "This code is deprecated. Install the " DRM_PORT = " pkg\n"); \ + device_printf(dev, DRM_MSG); \ device_printf(dev, "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D\n"); \ gone_in_dev(dev, 13, "drm2 drivers"); \ } while (0) +#endif /* __arm__ */ /* DRM_READMEMORYBARRIER() prevents reordering of reads. * DRM_WRITEMEMORYBARRIER() prevents reordering of writes.