From owner-svn-src-head@FreeBSD.ORG Mon Apr 13 20:43:35 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C21381065700; Mon, 13 Apr 2009 20:43:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5C9A48FC20; Mon, 13 Apr 2009 20:43:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 6E00746B2C; Mon, 13 Apr 2009 16:43:33 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id C19268A04D; Mon, 13 Apr 2009 16:43:27 -0400 (EDT) From: John Baldwin To: Tim Kientzle Date: Mon, 13 Apr 2009 16:30:25 -0400 User-Agent: KMail/1.9.7 References: <200903181619.n2IGJifl031031@svn.freebsd.org> <200903181406.32619.jhb@freebsd.org> <49E398F2.7090604@freebsd.org> In-Reply-To: <49E398F2.7090604@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904131630.25715.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 13 Apr 2009 16:43:27 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=4.2 tests=RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189967 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 20:43:36 -0000 On Monday 13 April 2009 3:56:34 pm Tim Kientzle wrote: > John Baldwin wrote: > > On Wednesday 18 March 2009 12:19:44 pm John Baldwin wrote: > >> Author: jhb > >> Date: Wed Mar 18 16:19:44 2009 > >> New Revision: 189967 > >> URL: http://svn.freebsd.org/changeset/base/189967 > >> > >> Log: > >> The zfs_get_xattrdir() function is used to find the extended attribute > >> directory for a znode. When the directory already exists, it returns a > >> referenced but unlocked vnode. When a directory does not yet exist, it > >> calls zfs_make_xattrdir() to create a new one. zfs_make_xattrdir() returns > >> the vnode both referenced and and locked and zfs_get_xattrdir() was leaking > >> this vnode lock to its callers. Fix this by dropping the vnode lock if > >> zfs_make_xattrdir() successfully creates a new extended attribute > >> directory. > > > > This should fix the panics with ZFS and tar + EA. > > Thanks. > > One point I'm curious about. This problem was > originally triggered by calls to extattr_list_fd(). > This seems to imply that any call to extattr_list_fd() > will allocate an extended attribute directory if it > doesn't already exist. > > This is surprising. It also raises questions about > both performance (tar now does extattr_list_fd() > for every file being archived) and operation > with read-only mounts. I'm not sure if it actually allocates space on disk or if it just allocates a virtual node to handle EA requests that only allocates disk space once it has at least one attribute to store. -- John Baldwin