From owner-cvs-all Sun Nov 5 8:34:23 2000 Delivered-To: cvs-all@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 0488837B4C5; Sun, 5 Nov 2000 08:34:16 -0800 (PST) Received: from localhost (qngvcn@localhost [127.0.0.1]) by green.dyndns.org (8.11.0/8.11.0) with ESMTP id eA5GY6532929; Sun, 5 Nov 2000 11:34:08 -0500 (EST) (envelope-from green@FreeBSD.org) Message-Id: <200011051634.eA5GY6532929@green.dyndns.org> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: Don Lewis Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc MAKEDEV src/release Makefile In-Reply-To: Message from Don Lewis of "Sun, 05 Nov 2000 07:34:59 PST." <200011051534.HAA97058@freefall.freebsd.org> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 05 Nov 2000 11:34:05 -0500 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Don Lewis wrote: > truckman 2000/11/05 07:34:59 PST > > Modified files: > etc MAKEDEV > release Makefile > Log: > Change MAKEDEV so that it prepends /sbin:/bin to $PATH instead of totally > overwriting $PATH, and find mknod $PATH instead of hardcoding /sbin so > that the copy of MAKEDEV on the fixit floppy is usable, since mknod and > expr live in /mnt2/stand when the fixit floppy is running. Ack! The idea of MAKEDEV having a restricted path is to prevent people from repeatedly using stuff from /usr/bin etc. in MAKEDEV, which they love to do. This change breaks that. The right thing to do would be to either one of: 1) Change the default PATH in MAKEDEV to include the fixit floppy's paths. 2) Make the fixit floppy set MAKEDEVPATH=/sbin:/bin:/mnt2/stand. The second is preferred because there's no telling if /mnt2/stand is really what you want to be executing stuff from in the non-fixit case. MAKEDEVPATH should be a subset of $PATH consisting only of the bare minimum programs that would in a normal system be all in the root partition. -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message