From owner-freebsd-amd64@FreeBSD.ORG Sat Feb 11 07:48:27 2012 Return-Path: Delivered-To: freebsd-amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F3E2106564A for ; Sat, 11 Feb 2012 07:48:27 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id D77E28FC15 for ; Sat, 11 Feb 2012 07:48:26 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q1B7mCLd088135 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 11 Feb 2012 09:48:12 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q1B7mCx7055340; Sat, 11 Feb 2012 09:48:12 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q1B7mBuQ055339; Sat, 11 Feb 2012 09:48:11 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 11 Feb 2012 09:48:11 +0200 From: Konstantin Belousov To: Russell Cattelan Message-ID: <20120211074811.GR3283@deviant.kiev.zoral.com.ua> References: <201202110430.q1B4UGPe088047@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="32mFWuI8C7a/mRQ2" Content-Disposition: inline In-Reply-To: <201202110430.q1B4UGPe088047@freefall.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-amd64@freebsd.org Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2012 07:48:27 -0000 --32mFWuI8C7a/mRQ2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 11, 2012 at 04:30:16AM +0000, Russell Cattelan wrote: > The following reply was made to PR amd64/163710; it has been noted by GNA= TS. >=20 > From: Russell Cattelan > To: bug-followup@FreeBSD.org, cattelan@thebarn.com > Cc: =20 > Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption > Date: Fri, 10 Feb 2012 22:04:52 -0600 >=20 > So here is a suggestion. > =20 > So the default build does do the right thing. > =20 > The problem is when doing userboot development the > symlink from the loader build ends up including the wrong > files. > =20 > the userboot build of fill does not need a sym link so make > sure the link does not exist when doing the build. > =20 > This make sure the right header files are used for userboot builds=3D20 I suspect this will break cross-builds. If the issue is in wrong machine/ symlink being installed, should this be fixed instead ? > =20 > diff --git a/sys/boot/userboot/ficl/Makefile =3D > b/sys/boot/userboot/ficl/Makefile > index 829ae1e..6249eb2 100644 > --- a/sys/boot/userboot/ficl/Makefile > +++ b/sys/boot/userboot/ficl/Makefile > @@ -61,6 +61,10 @@ softcore.c: ${SOFTWORDS} softcore.awk > (cd ${.CURDIR}/../../ficl/softwords; cat ${SOFTWORDS} \ > | awk -f softcore.awk -v datestamp=3D3D"`LC_ALL=3D3DC date`") > =3D > ${.TARGET} > =3D20 > +beforedepend ${OBJS}: no-machine > + > +no-machine: > + rm -f ${.CURDIR}/../../ficl/machine > #.if ${MACHINE_CPUARCH} =3D3D=3D3D "amd64" > #${SRCS:M*.c:R:S/$/.o/g}: machine > # > =20 > =20 > _______________________________________________ > freebsd-amd64@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-amd64 > To unsubscribe, send any mail to "freebsd-amd64-unsubscribe@freebsd.org" --32mFWuI8C7a/mRQ2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk82HTsACgkQC3+MBN1Mb4hMZQCgz12tI+vwm8VxV0cFd5c5wlSH 3bcAoO8TXXbRTgTVkf8oMc415shGfqQW =zk5U -----END PGP SIGNATURE----- --32mFWuI8C7a/mRQ2--