From owner-cvs-lib Mon Mar 24 09:08:45 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id JAA18567 for cvs-lib-outgoing; Mon, 24 Mar 1997 09:08:45 -0800 (PST) Received: from rover.village.org (rover.village.org [204.144.255.49]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id JAA18405; Mon, 24 Mar 1997 09:05:25 -0800 (PST) Received: from rover.village.org [127.0.0.1] by rover.village.org with esmtp (Exim 0.56 #1) id E0w9DA2-0005II-00; Mon, 24 Mar 1997 10:03:54 -0700 To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= Subject: Re: cvs commit: src/lib/libc/stdtime localtime.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-lib@freefall.freebsd.org In-reply-to: Your message of "Mon, 24 Mar 1997 19:25:28 +0300." References: Date: Mon, 24 Mar 1997 10:03:54 -0700 From: Warner Losh Message-Id: Sender: owner-cvs-lib@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In message =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= writes: : I forget to note that this change should be backed out in any case. : It broke whole TZ idea. If you need check, do it properly checking : ranges and overflowes inside localtime code itself, not by disallowing : tz file opening. Ummm, my tests show that it works with all standard TZ values (at least the ones I samples EST, EST5EDT, America/New_York). It didn't work with /home/imp/bogus/time/zone, which was the intent of the change. If my tests were flawed, then please let me know what I broke. I tested this with a setuid copy of date. Any my commit message was horrible in that it cause confusion. All I intended to do was to disallow non-standard places. If that isn't the case, please let me know. Warner