Date: Mon, 16 Apr 2007 19:10:17 +0200 From: Pieter de Goeje <pieter@degoeje.nl> To: freebsd-hackers@freebsd.org Cc: Zhang Weiwu <zhangweiwu@realss.com> Subject: Re: a simple patch to enable RFC2640 for /usr/libexec/ftpd Message-ID: <200704161910.17794.pieter@degoeje.nl> In-Reply-To: <1176725221.17708.16.camel@joe.realss.com> References: <1176725221.17708.16.camel@joe.realss.com>
next in thread | previous in thread | raw e-mail | index | archive | help
I think your patch looks good, however there have been some changes to ftpd since 6.1. Also, since lukemftp is imported from NetBSD, you might want to contact the original author so future imports won't discard this new feature. On Monday 16 April 2007, Zhang Weiwu wrote: > family = (family == AF_INET) ? AF_UNSPEC : > AF_INET6; break; > + > + case '8': > + utf8_mode = 1; Add missing break statement here? > > case 'a': > bindname = optarg; Cheers, Pieter de Goeje
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704161910.17794.pieter>