Date: Sat, 16 Apr 2016 09:01:02 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: Michael <mike@reifenberger.com> Cc: marino@freebsd.org, John Marino <freebsd.contact@marino.st>, Michael Reifenberger <mr@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r413435 - in head/cad/kicad-devel: . files Message-ID: <201604161601.u3GG12oo008165@slippy.cwsent.com> In-Reply-To: Message from Michael <mike@reifenberger.com> of "Sat, 16 Apr 2016 15:36:52 %2B0200." <29F940DD-A600-4DED-89BF-FFE87EA4821D@reifenberger.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <29F940DD-A600-4DED-89BF-FFE87EA4821D@reifenberger.com>, Michael wri tes: > Hi, > I just want to ensure that the patch doesn't harm on the currently building a > rchs. > > Greetings > ... > Mike > Why would you need to "ensure" no "harm" is done elsewhere? Has this been tested? -- Cheers, Cy Schubert <Cy.Schubert@komquats.com> or <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. > Am 16. April 2016 13:38:16 MESZ, schrieb John Marino <freebsd.contact@marino. > st>: > >On 4/16/2016 1:22 PM, Michael Reifenberger wrote: > >> Author: mr > >> Date: Sat Apr 16 11:22:54 2016 > >> New Revision: 413435 > >> URL: https://svnweb.freebsd.org/changeset/ports/413435 > >> > >> Log: > >> Try to fix comilation under FreeBSD-9 > >> > >> Added: > >> > >head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h > > (contents, props changed) > >> Modified: > >> head/cad/kicad-devel/Makefile > >> > >> Modified: head/cad/kicad-devel/Makefile > >> > >============================================================================ > == > >> --- head/cad/kicad-devel/Makefile Sat Apr 16 11:22:53 2016 (r41343 > 4) > >> +++ head/cad/kicad-devel/Makefile Sat Apr 16 11:22:54 2016 (r41343 > 5) > >> @@ -3,7 +3,7 @@ > >> > >> PORTNAME= kicad > >> DISTVERSION= r${BZR_SRC_REV} > >> -#PORTREVISION= 1 > >> +PORTREVISION= 1 > >> CATEGORIES= cad > >> MASTER_SITES= LOCAL/mr > >> PKGNAMESUFFIX= -devel > >> > >> Added: > >head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h > >> > >============================================================================ > == > >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) > >> +++ > >head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h > Sat > >Apr 16 11:22:54 2016 (r413435) > >> @@ -0,0 +1,8 @@ > >> +--- include/gal/graphics_abstraction_layer.h.orig 2016-04-16 > >13:14:32.003824016 +0200 > >> ++++ include/gal/graphics_abstraction_layer.h 2016-04-16 > >13:15:06.143789160 +0200 > >> +@@ -31,4 +31,5 @@ > >> + #include <stack> > >> + #include <limits> > >> ++#include <cmath> > >> + > >> + #include <math/matrix3x3.h> > >> > > > >Why bump PORTREVISION? > >For all those platforms that kicad-devel built on, now they have to > >rebuild it again completely unnecessarily. > > > >In my opinion, this change did not warrant a PORTREVISION bump. > > > >John >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604161601.u3GG12oo008165>